344459 - Deleting name for bookmark then selecting a microsummary doesn't enable OK button in bookmarks dialog

Status: RESOLVED FIXED

(Firefox Graveyard :: Microsummaries, defect)

Description

[Daniel McKenzie]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1

If you have a microsummary for a page, adding a bookmark and deleting the text in the "Name" field will disable the OK button. However, if you select a Live Title after this the OK button will not enable until you have entered one or two characters (and hence canceling the Live Title selection).

Reproducible: Always

Steps to Reproduce:
1. Go to a page that either has a microsummary, or where you have installed a microsummary for that page. (For example, the provided URL).
2. Go to Bookmarks > Add a Bookmark.
3. Delete all text in the Name field.
4. Click the Name dropdown and select the microsummary (or Live Title).

Actual Results:  
The OK button doesn't enable.

Expected Results:  
The OK button should be enabled.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: fix

Right, this useless-ui is getting on my nerves. This patch fixes this bug and bug 304740 (you can't add a bookmark with no title, but you are more than welcome to remove the title in the bookmark's properties) and bandaids one case of bug 304145 (undo in Keyword still won't enable the button, but requiring a Keyword for a Keyword makes more sense) as well as one case of the probably unreported (except as Core:DnD) bug where dropping text in an empty field won't enable the button.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/bookmarks/content/addBookmark2.js 	1.43

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 229046 [details] [diff] [review]
fix

Notes for drivers considering this approval request:

This patch fixes a variety of edge cases in which the OK button doesn't get enabled in the bookmarks dialog, even though the user has made changes that it should be possible to save.  It is a trivial patch with a low risk of regressions (the only potential issue would be whether the code that performs the save operation isn't prepared to handle these edge cases).  It has been on the trunk since Wednesday morning.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 229046 [details] [diff] [review]
fix

a=mconnor on behalf of drivers for checkin to the 1.8 branch