text.xml#text-link : backport accessible and event handler changes from the toolkit version

RESOLVED WONTFIX

Status

--
enhancement
RESOLVED WONTFIX
12 years ago
11 years ago

People

(Reporter: philip.chee, Assigned: jag-mozilla)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
These bugs were filed against Toolkit.

Bug 280065 XUL text-link widget is not accessible (approval1.8b4+)
Bug 302683 Get More Themes (Extensions) doesn't launch a browser (approval1.8b4+)
Bug 312846 Pressing Enter when a UI-link is focused inside a wizard advances the wizard (approval1.8rc1+)
Bug 315166 Make the text-link binding be more careful about which protocols it allows, r=mconnor (security?!?)

LXR:
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/text.xml
http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/text.xml

We should update our xpfe XBL with the toolkit changes.

A side effect of this patch is to make the xpfe and toolkit versions identical making the transition to SuiteRunner marginally easier.

These changes were made before the 1.8.0 branch was cut so I think this patch could make it to the SeaMonkey 1.0.x and 1.1 branches. Especially the security sensitive one (The security sensitive flag could be removed - the comments in the source already reveal the details).
(Reporter)

Comment 1

12 years ago
Created attachment 229069 [details] [diff] [review]
Patch v1
(Reporter)

Comment 2

12 years ago
This bit appears to be for Thunderbird only, do we need this.

+            // if the scheme is not an exposed protocol, then opening this link
+            // should be deferred to the system's external protocol handler
+            if (!protocolSvc.isExposedProtocol(uri.scheme)) {
+              protocolSvc.loadUrl(uri);
+              aEvent.preventDefault()
+              return;
+            }
(Reporter)

Updated

12 years ago
Attachment #229069 - Flags: review?(neil)
(Reporter)

Updated

12 years ago
Attachment #229069 - Flags: superreview?(neil)

Comment 3

12 years ago
Created attachment 229243 [details] [diff] [review]
My approach

So, I gave in and dug out the patch that I'd started to implement this without all the crap that has polluted toolkit, but it's very much untested.
(Reporter)

Comment 4

12 years ago
Created attachment 229922 [details]
Test Case for label.text-link

Tested Neil's patch on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060714 SeaMonkey/1.5a with this test case.

Works For Me with one nit:

Warning: Expected color but found 'invert'.  Expected color but found 'invert'.  Expected end of value for property but found 'invert'.  Error in parsing value for property 'border'.  Declaration dropped.
Source File: chrome://global/skin/formatting.css
Line: 245

-.text-link:focus {
+html|a:focus {
   color: red;
-  outline: 1px dotted invert;
+  border: 1px dotted invert;
 }

According to W3C, invert only works for outline-color.
I'm not sure why Neil changed outline to border though.

Note: I don't have a Mac so I haven't tested the Mac OSX specific CSS changes.
(Reporter)

Updated

12 years ago
Whiteboard: [checkin needed]
(Reporter)

Comment 5

12 years ago
Gah. Wrong bug.
Whiteboard: [checkin needed]

Updated

11 years ago
Attachment #229069 - Attachment is obsolete: true
Attachment #229069 - Flags: superreview?(neil)
Attachment #229069 - Flags: review?(neil)
(Reporter)

Comment 6

11 years ago
SeaMonkey trunk is now on toolkit and thus using the toolkit bindings.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.