344660 - Show frame count for animated GIFs in Image Properties

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Michael Ventnor]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1

I was thinking of another feature Firefox could use. The image properties in the Element properties window could show the total number of frames in the selected animated GIF/MNG.

Reproducible: Always

Comment 1

[Florian Quèze [:florian]]

Attachment: patch v1

Currently we display:
 Type: Image/xxx

With this patch, if the image isn't animated, we display:
 Type: XXX Image

If the image is animated:
 Type: Animated XXX Image (N frames)

If the mime type doesn't begin with 'image/',
 Type: mimetype

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 260640 [details] [diff] [review]
patch v1

Not sure that the framecount is really neccessary. I would also suggest that the format be:

%s image

and

%S image (animated, %s frames)

for easier reading.

Comment 3

[Florian Quèze [:florian]]

Attachment: patch v2

updated patch. Requesting review.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 260643 [details] [diff] [review]
patch v2

>Index: browser/base/content/metaData.js
>===================================================================

>+      if (imageRe.test(imageType))
>+      {

just inline the regep, the brace should be on the same line with the condition.

>+        imageType = imageRe.exec(imageType)[1].toUpperCase();
>+        var frameCount = imageRequest.image.numFrames;
>+        if (frameCount > 1)
>+          imageType = gMetadataBundle.getFormattedString("animatedImageType", [imageType, frameCount]);
>+        else
>+          imageType = gMetadataBundle.getFormattedString("imageType", [imageType]);

please keep code lines no longer than 80 characters

r=mano otherwise.

Comment 5

[Florian Quèze [:florian]]

Attachment: patch v3

Comment 6

[Florian Quèze [:florian]]

Attachment: full patch v3

The metadata.properties part was missing in the previous attachment.

Comment 7

[Asaf Romano (gone)]

mozilla/browser/base/content/metaData.js 1.15
mozilla/browser/locales/en-US/chrome/browser/metaData.properties 1.5

Comment 8

[smeeze]

This useful feature was introduced way back when. Why was it removed?

Comment 9

[Florian Quèze [:florian]]

(In reply to smeeze from comment #8)
> This useful feature was introduced way back when. Why was it removed?

I don't think it has been intentionally removed.

From looking at the source code history, it seems it got broken by http://hg.mozilla.org/mozilla-central/rev/f99cedbbc5f6 from bug 584841 comment 51.

If you think it should be re-added / fixed, would you mind filing a bug for it?