Open
Bug 344674
Opened 18 years ago
Updated 2 years ago
Merge nsIAccessible::GetExtState() into GetState() by using |long long| type
Categories
(Firefox :: Disability Access, enhancement)
Tracking
()
REOPENED
People
(Reporter: aaronlev, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
184.27 KB,
patch
|
Details | Diff | Splinter Review |
In the past we used two separate methods because we were told that there were problems with long long. Apparently older compilers could not handle it smoothly. Looking at bug 264599, I see we use |long long| in many places. So, apparently this work can be done now.
Comment 2•17 years ago
|
||
Now, we can't define long long constants in idl (bug 374231). There is other possible problem with precision of JS. Also, sayrer said on irc: "but larger numbers are silently converted to doubles... watch out".
Comment 3•17 years ago
|
||
You will say I'm crazy but I ran out on the problem when I started to test the patch :(. The patch is not tested and even is not compiled. Probably once it will be helpful.
Reporter | ||
Comment 4•17 years ago
|
||
Hi Alexander, can you use -u for unified diff? Also, I didn't understand about your last comment. Do you mean you want to come back to this some time later?
Comment 5•17 years ago
|
||
(In reply to comment #4) > Hi Alexander, can you use -u for unified diff? Sure I will. > Also, I didn't understand about your last comment. Do you mean you want to come > back to this some time later? > I have not another way. I cannot define long long constants in idl. When it will be fixed then I can return to this.
Reporter | ||
Comment 7•17 years ago
|
||
You could just make GetState have 2 32 bit out params for now. It's a middle step. Then later it will be easier to change. Up to you.
Comment 8•17 years ago
|
||
(In reply to comment #7) > You could just make GetState have 2 32 bit out params for now. It's a middle > step. Then later it will be easier to change. Up to you. > I'm thinkin I will.
Assignee: nobody → surkov.alexander
Updated•15 years ago
|
Comment 9•11 years ago
|
||
It'd be nice but not a priority these days. Unassigning.
Assignee: surkov.alexander → nobody
Comment 10•6 years ago
|
||
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
Updated•6 years ago
|
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•