Open Bug 344674 Opened 18 years ago Updated 2 years ago

Merge nsIAccessible::GetExtState() into GetState() by using |long long| type

Categories

(Firefox :: Disability Access, enhancement)

x86
All
enhancement

Tracking

()

REOPENED

People

(Reporter: aaronlev, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

In the past we used two separate methods because we were told that there were problems with long long. Apparently older compilers could not handle it smoothly.

Looking at bug 264599, I see we use |long long| in many places.

So, apparently this work can be done now.
Anyone want to take this bug?
Severity: normal → enhancement
No longer blocks: keya11y
Depends on: 374231
Now, we can't define long long constants in idl (bug 374231). There is other possible problem with precision of JS. Also, sayrer said on irc: "but larger numbers are silently converted to doubles... watch out".
Attached patch patch (obsolete) — Splinter Review
You will say I'm crazy but I ran out on the problem when I started to test the patch :(. The patch is not tested and even is not compiled. Probably once it will be helpful.
Hi Alexander, can you use -u for unified diff?

Also, I didn't understand about your last comment. Do you mean you want to come back to this some time later?
(In reply to comment #4)
> Hi Alexander, can you use -u for unified diff?

Sure I will.

> Also, I didn't understand about your last comment. Do you mean you want to come
> back to this some time later?
> 

I have not another way. I cannot define long long constants in idl. When it will be fixed then I can return to this.
Attached patch patch2Splinter Review
with up8N
Attachment #258809 - Attachment is obsolete: true
You could just make GetState have 2 32 bit out params for now. It's a middle step. Then later it will be easier to change. Up to you.
(In reply to comment #7)
> You could just make GetState have 2 32 bit out params for now. It's a middle
> step. Then later it will be easier to change. Up to you.
> 

I'm thinkin I will.
Assignee: nobody → surkov.alexander
Depends on: 374390
Depends on: cleana11y
Blocks: cleana11y
No longer depends on: cleana11y
It'd be nice but not a priority these days. Unassigning.
Assignee: surkov.alexander → nobody
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: