344689 - CertViewer is missing some accesskeys

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.4) Gecko/20060614 Fedora/1.5.0.4-1.2.fc5 Firefox/1.5.0.4 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.4) Gecko/20060614 Fedora/1.5.0.4-1.2.fc5 Firefox/1.5.0.4 pango-text

General and Details tabs don't have accesskeys.
Even the close button is missing its own (even if it is defined in the .dtd file).

Reproducible: Always

Comment 1

[Giacomo Magnini]

Attachment: This should be enough

Comment 2

[Kai Engert (:KaiE:)]

Comment on attachment 229255 [details] [diff] [review]
This should be enough

looks good, thanks for the patch.

r=kengert, assuming you tested it

Comment 3

[Giacomo Magnini]

(In reply to comment #2)
> (From update of attachment 229255 [details] [diff] [review] [edit])
> looks good, thanks for the patch.
> 
> r=kengert, assuming you tested it

Yeah, I did.

Comment 4

[Giacomo Magnini]

Comment on attachment 229255 [details] [diff] [review]
This should be enough

Neil: not sure you are the right one to ask sr from... Sorry in advance if it's not the case.

Comment 5

[Martijn Wargers (dead)]

Checking in pki/resources/content/certViewer.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/certViewer.xul,v  <--  c
ertViewer.xul
new revision: 1.19; previous revision: 1.18
done
Checking in locales/en-US/chrome/pippki/certManager.dtd;
/cvsroot/mozilla/security/manager/locales/en-US/chrome/pippki/certManager.dtd,v
 <--  certManager.dtd
new revision: 1.4; previous revision: 1.3
done

Checked into trunk, thanks for the patch, Giacomo!