[meta] debug builds corresponding to releases must not be allowed to trigger assertions and spew lots of warnings

NEW
Unassigned

Status

()

12 years ago
5 years ago

People

(Reporter: eyalroz, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
It is very inconvenient, difficult even, for a developer to work on fixing a bug in one of the Mozilla apps, when your screen fills up with WARNING, DANGER WILL ROBINSON, etc. messages on stderr whenever you run your build - and what's worse, assertions get triggered, interrupting the normal interaction with the UI and sometime even preventing the possibility of decently testing your code (e.g. when it involves timed events).

Now, granted, this can't be avoided completely, but I would think that at least releases should not be made until at least there are no assertions triggered during normal use on the major platform, and the number of warning messages is reduced to a minimum - with this minimum being described somewhere (addendum to the release notes?)

I believe this would make contributing developers' lives a whole lot easier.

Comment 1

12 years ago
Can you paste some of the warnings you're encountering, or give bug numbers for them?
(Reporter)

Comment 2

12 years ago
Created attachment 229373 [details] [diff] [review]
tbird warnings on startup

This is from a tbird build from the 1.5.0.4 source tarball.
(Reporter)

Comment 3

12 years ago
I also get ASSERTION: Have global without context?: 'mScriptGlobals[lang_ndx] == nsnull' file e:/moztools/src/mozilla/content/xul/document/src/nsXUL PrototypeDocument.cpp, line 846 when I click the tree root of some of my mail accounts (in this case, IMAP), and when I first started tbird after building it, I got more assertion failures.
(Reporter)

Comment 4

12 years ago
Immediately after 'ignore'ing the previous assertion, I get:

ASSERTION: Lying nsIInterfaceRequestor implementation!: '*aResult', file e:/moztools/src/mozilla/content/base/src/nsXMLHttpRequest.cpp, line 2031
(Reporter)

Comment 5

12 years ago
And a third assertion:

ASSERTION: nsWeakReference not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file e:/moztools/src/mozilla/xpcom/build/nsWeakReference.cpp, line 146

Comment 6

12 years ago
You had me confused by using "release" to mean branch (as opposed to trunk).  It's usually used to mean "non-debug" (as opposed to debug).  Resummarizing.

Most Mozilla developers on Windows have XPCOM_DEBUG_BREAK set to "warn" so that assertions won't bring up dialogs.  (Mozilla developers on other platforms don't have to, because that or something similar is the default on Windows and Mac.)  Making that change to your environment should take care of a lot of the annoyance of assertions and the interference with timers.

That said, console noise annoys the heck out of me too.  I have a similar metabug, bug 341986.
Summary: [meta] release builds must not be allowed to trigger assertions and spew lots of warnings → [meta] debug builds corresponding to releases must not be allowed to trigger assertions and spew lots of warnings

Comment 7

5 years ago
I see no specific request associated to the qawanted keyword here. Is there anything you need from QA for this bug?

Updated

5 years ago
Keywords: qawanted
You need to log in before you can comment on or make changes to this bug.