344795 - Downloading files causes the current tab to close when SWM set to reuse

Status: RESOLVED DUPLICATE of bug 344808

(Core :: DOM: Navigation, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I've seen this happen a couple of times starting recently, but I haven't figured out what's causing it yet, or why only some downloads.  Sometimes a download causes the current tab to close while I'm reading it....

Very annoying; I first started seeing it sometime this week....

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Dummy attachment for testcase

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: testcase

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

So, this regressed between 2006-07-06-07-07 and 2006-07-07-05 on the 1.8branch, which makes bug 241972 seem like the most likely candidate: http://tinyurl.com/fp8qr

This also seems to require your SWM prefs be set to "reuse" rather than "new tab" or "off/new windows" (although there's a more-user-activated sub-case that could be triggered in the latter 2 settings).

When SWM is set to "reuse" (browser.link.open_newwindow, 1), recent nightlies will close the window you're viewing if you've clicked a link to a download where the download has a target.  This is a common scenario on forums, for example.  Prior to that bug landing, you clicked the link, the download started, you remained on the same page and continued reading the thread.

1) When SWM is set to reuse, no new window is ever created (unlike with SWM "off" or SWM set to "new tabs"), so no window should be closed by the "download-closing hueristic".

2) Even worse, if you were to navigate away from the page before the download finished, the window will still be closed (if you have SWM set to "new tabs" or "off", manually going somewhere in the otherwise blank new window/tab will also run afoul of this bug). The hueristic should unset its "this needs to be closed" flag if the url of the window/tab changes between the time the flag is set and the time at which the window/tab is closed.

Oddly enough, this behaves correctly for data: urls; the active tab doesn't get closed (which I suppose means it's broken for data: urls when SWM is set to "new tabs" or "new windows")....

This is Core somewhere, obviously...guessing Docshell since files there were touched and SWM also lives there, iirc.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Note that the "reuse" setting is basically unsupported and has known crash issues.  I strongly feel that we should just remove it altogether...

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Did the fix for bug 344808 fix this on the trunk, too?  It sounded similar, and I can't reproduce using the testcase anymore.

Comment 6

[froodian (Ian Leue)]

I can still repro at least behavior 1 on Camino 2006080222 (1.2+).  The download goes by too quickly for me to accurately test behavior 2.

Comment 7

[Boris Zbarsky [:bzbarsky]]

> I can still repro at least behavior 1 on Camino 2006080222 

The fix for bug 344808 was "checked in on trunk on 2006-08-02 23:22" (as you can see from bug 344808 comment 34).  So please retest in a more recent build.  This looks like a duplicate of bug 344808.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Duping per comment 7.

*** This bug has been marked as a duplicate of 344808 ***