Closed Bug 344812 Opened 14 years ago Closed 13 years ago

string ID typo in CertViewer: fix display of KU_CRL_SIGN key usage bit

Categories

(Core Graveyard :: Security: UI, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbugz, Assigned: KaiE)

References

Details

(Keywords: verified1.8.1.1)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: 

There's a small typo in the patch submitted with bug 259031 - the BundleString identifier for the "CRL Signer" key usage is incorrect, thereby preventing it from being displayed (it will simply be omitted, even if the cert has this keyUsage bit set): instead of

  if (keyUsage & KU_CRL_SIGN) {
    nssComponent->GetPIPNSSBundleString("CertDumpKUCRLSign", local);

it should read

  if (keyUsage & KU_CRL_SIGN) {
    nssComponent->GetPIPNSSBundleString("CertDumpKUCRLSigner", local);

(that's line 748 in the trunk version of nsNSSCertHelper.cpp, see http://lxr.mozilla.org/mozilla/source/security/manager/ssl/src/nsNSSCertHelper.cpp#748)

Reproducible: Always

Steps to Reproduce:
In the CertManager, select the root certificate for https://bugzilla.mozilla.org, i.e. the "GlobalSign Root CA" builtin token, and go to the "Certificate Key Usage" extension in the "Details" tab.
Actual Results:  
"Field Value" will only indicate "Certificate Signer"

Expected Results:  
Should indicate both "Certificate Signer" and "CRL Signer"
Depends on: 259031
As I realized in the meantime, it's actually not bug 259031 where this mistake was introduced, but bug 78012 instead... - yes, this happened in May 2001 already (and apparently nobody noticed so far). Fixing the spelling in nsNSSCertHelper.cpp is probably the better choice than fixing pipnss.properties, since the spelling in the latter one (i.e. "CertDumpKUCRLSigner") might have been referenced by other .cpp files meanwhile.
Depends on: 78012
No longer depends on: 259031
I confirm the reported bug.
Kaspar, please attach a patch to correct it.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #240019 - Flags: review?(kengert)
Comment on attachment 240019 [details] [diff] [review]
proposed patch (against trunk)

r=kengert

I'll check this obvious correctness patch into the trunk, thanks for the patch.
Attachment #240019 - Flags: review?(kengert) → review+
Nominating for 1.8.1.1 in case it won't make 1.8.1
(there is no patch approval flag for 1.8.1.1 yet)
Flags: blocking1.8.1.1?
Summary: CertViewer: fix display of KU_CRL_SIGN key usage bit → string ID typo in CertViewer: fix display of KU_CRL_SIGN key usage bit
fixed on trunk
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 240019 [details] [diff] [review]
proposed patch (against trunk)

approved for 1.8 branch, a=dveditz for drivers
Attachment #240019 - Flags: approval1.8.1.1+
Flags: blocking1.8.1.1? → blocking1.8.1.1+
Keywords: fixed1.8.1.1
following description in comment 1, confirmed presence of bug in 1.5.0.8, verified fixed for 1.8.1.1

verified 1.8.1.1
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.1pre) Gecko/2006113003 BonEcho/2.0.0.1pre
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.