344855 - Create a subroutine that does all of checksetup's requirements checking

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Max Kanat-Alexander]

Now that the mandatory and optional requirements data is in Bugzilla::Install::Requirements, that module should also have a check_requirements() subroutine that does everything in the "Requirements" section of Bugzilla. (Except check the perl version, which we do before this.)

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Here's my patch. I've run it through test-checksetup and runtests.pl, so it works as far as I know.

Comment 2

[Max Kanat-Alexander]

Attachment: v2

I fixed the output of checksetup.pl to be more consistent for printing out the optional and required modules. I also fixed the line lengths and a tiny bug in the old patch.

Comment 3

[Max Kanat-Alexander]

I'm the module owner, and I'm fairly confident about this patch. Requesting approval directly.

Comment 4

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.515; previous revision: 1.514
done
Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.45; previous revision: 1.44
done
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.9; previous revision: 1.8
done