Create a subroutine that does all of checksetup's requirements checking

RESOLVED FIXED in Bugzilla 3.0

Status

()

--
enhancement
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: mkanat, Assigned: mkanat)

Tracking

2.23
Bugzilla 3.0
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
Now that the mandatory and optional requirements data is in Bugzilla::Install::Requirements, that module should also have a check_requirements() subroutine that does everything in the "Requirements" section of Bugzilla. (Except check the perl version, which we do before this.)
(Assignee)

Comment 1

12 years ago
Created attachment 231031 [details] [diff] [review]
v1

Here's my patch. I've run it through test-checksetup and runtests.pl, so it works as far as I know.
(Assignee)

Comment 2

12 years ago
Created attachment 231034 [details] [diff] [review]
v2

I fixed the output of checksetup.pl to be more consistent for printing out the optional and required modules. I also fixed the line lengths and a tiny bug in the old patch.
Attachment #231031 - Attachment is obsolete: true
(Assignee)

Comment 3

12 years ago
I'm the module owner, and I'm fairly confident about this patch. Requesting approval directly.
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 4

12 years ago
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.515; previous revision: 1.514
done
Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.45; previous revision: 1.44
done
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.9; previous revision: 1.8
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.