Closed
Bug 344872
Opened 19 years ago
Closed 19 years ago
Mail window is leaking folderObserver on shutdown
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird2.0
People
(Reporter: ispiked, Assigned: ispiked)
Details
(Keywords: fixed1.8.1, memory-leak)
Attachments
(2 files, 1 obsolete file)
|
1.60 KB,
text/plain
|
Details | |
|
1.96 KB,
patch
|
ispiked
:
review+
mscott
:
approval-thunderbird2+
|
Details | Diff | Splinter Review |
Using a current trunk build.
Steps to reproduce:
1. Open and close Thunderbird with Leak Monitor installed.
Results:
Leak Monitor prints out that we're leaking an object on shutdown.
Expected Results:
No leak.
|
Assignee | |
Comment 1•19 years ago
|
||
We're leaking the folderObserver object in msgMail3PaneWindow.js [0] that we add an observer to and never remove it [1].
[0] http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mail/base/content/msgMail3PaneWindow.js&rev=1.89&mark=350-388#349
[1] http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mail/base/content/msgMail3PaneWindow.js&rev=1.89&mark=1151#1129
|
|
Assignee | |
Comment 2•19 years ago
|
||
|
|
Assignee | |
Updated•19 years ago
|
Attachment #229413 -
Flags: review? → review?(bienvenu)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 229413 [details] [diff] [review]
fix
Thx for the patch!
but probably don't need the folderTree var - can just do var folderTreeBuilder = GetFolderTree().builder.QueryInterface...
Attachment #229413 -
Flags: review?(bienvenu) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Ah, good point. This bug fixes a leak when closing the mail window and would be great to get into Thunderbird 2.
Attachment #229413 -
Attachment is obsolete: true
Attachment #229430 -
Flags: review+
Attachment #229430 -
Flags: approval-thunderbird2?
|
|
||
Comment 5•19 years ago
|
||
Comment on attachment 229430 [details] [diff] [review]
fix v2
nice. Thanks for the patch Adam!
Attachment #229430 -
Flags: approval-thunderbird2? → approval-thunderbird2+
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [checkin needed]
|
||
Comment 6•19 years ago
|
||
mozilla/mail/base/content/msgMail3PaneWindow.js 1.70.2.21
mozilla/mail/base/content/msgMail3PaneWindow.js 1.90
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Thunderbird2.0
Version: Trunk → 2.0
|
|
Assignee | |
Comment 7•19 years ago
|
||
David, you accidentally backed me out with your checkin for bug 74959! http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=msgMail3PaneWindow.js&branch=&root=/cvsroot&subdir=mozilla/mail/base/content&command=DIFF_FRAMESET&rev1=1.92&rev2=1.93
Can someone reland this on trunk and branch? Thanks!
Status: RESOLVED → REOPENED
Keywords: fixed1.8.1
Resolution: FIXED → ---
Whiteboard: [checkin needed][checkin needed (1.8 branch)]
|
||
Comment 8•19 years ago
|
||
Checking in msgMail3PaneWindow.js;
/cvsroot/mozilla/mail/base/content/msgMail3PaneWindow.js,v <-- msgMail3PaneWin
dow.js
new revision: 1.99; previous revision: 1.98
done
Checked in on trunk.
Checking in msgMail3PaneWindow.js;
/cvsroot/mozilla/mail/base/content/msgMail3PaneWindow.js,v <-- msgMail3PaneWin
dow.js
new revision: 1.70.2.27; previous revision: 1.70.2.26
done
Checked in on 1.8.1 branch.
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed][checkin needed (1.8 branch)]
You need to log in
before you can comment on or make changes to this bug.
Description
•