Closed Bug 344901 Opened 15 years ago Closed 15 years ago

Document frame accessible has no child

Categories

(Firefox :: Disability Access, defect)

All
Linux
defect
Not set
blocker

Tracking

()

RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

(Keywords: access)

Attachments

(1 file)

With nightly build, open www.google.com.
Use at-poke to poke firefox's accessible tree.
at-poke got no child for document frame. 

The regression is caused by last week's checkins.
Ginn, will you find out why? Right now I need to rebuild my Linux box.
Assignee: aaronleventhal → ginn.chen
Attached patch patchSplinter Review
fix the regression of fix of bug 312093
sorry for my careless review

p.s.
Aaron, lots of html pages have a structure like
<html><body><center> .... </center></body></html>
or
<html><body><div align="center"> .... </div></body></html>

Fix of bug 342035 will create an accessible object for the span or div.
Do you think it is redundant?
Attachment #229639 - Flags: review?(aaronleventhal)
Comment on attachment 229639 [details] [diff] [review]
patch

Thanks Ginn :)
Attachment #229639 - Flags: review?(aaronleventhal) → review+
(In reply to comment #2)
> Aaron, lots of html pages have a structure like
> <html><body><center> .... </center></body></html>
> or
> <html><body><div align="center"> .... </div></body></html>

Let's talk about this on IRC or email, but I think it's better to have a simple, predictable rule than a complex rule which tries to remove the redundancies.
Checked in for Ginn:

Checking in src/atk/nsAccessibleWrap.h;
/cvsroot/mozilla/accessible/src/atk/nsAccessibleWrap.h,v  <--  nsAccessibleWrap.h
new revision: 1.22; previous revision: 1.21
done
Checking in src/html/nsHyperTextAccessible.cpp;
/cvsroot/mozilla/accessible/src/html/nsHyperTextAccessible.cpp,v  <--  nsHyperTextAccessible.cpp
new revision: 1.7; previous revision: 1.6
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.