344980 - nsPrompt::PromptUsernameAndPassword does sometimes not set retval

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/source/netwerk/base/public/nsIAuthPrompt.idl

The boolean is the return value.

http://lxr.mozilla.org/seamonkey/source/embedding/components/windowwatcher/src/nsPrompt.cpp#375

But the code just returns NS_OK without touching the boolean if DefaultEnabled() returns false.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 229606 [details] [diff] [review]
patch

>Index: embedding/components/windowwatcher/src/nsPrompt.cpp

>+    // Default to cancel. answer and checkValue are inout parameters, so we
>+    // don't have to set it.

"set them"

r+sr=bzbarsky with that.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in with that change
Checking in embedding/components/windowwatcher/src/nsPrompt.cpp;
/cvsroot/mozilla/embedding/components/windowwatcher/src/nsPrompt.cpp,v  <--  nsPrompt.cpp
new revision: 1.24; previous revision: 1.23
done