Closed Bug 345024 Opened 15 years ago Closed 15 years ago

Not all numbers transliterated

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smontagu, Assigned: smontagu)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Not all numbers have entries in intl/unicharutils/tables/transliterate.properties.

To reproduce, view http://www.alanwood.net/unicode/kharoshthi.html on a system with no font coverage for these characters. (http://www.alanwood.net/unicode/aegean_numbers.html may also show the bug)

Expected results: all numbers are transliterated, so U+10A40 - U+10A47 appear as [1] [2] [3] [4] [10] [20] [100] [1000]

Actual results: only [10] [20] [100] are transliterated.
The steps to reproduce in comment 0 depend on the transliterator being used in font code. An alternative method is to copy and paste as plain text.
Attached patch PatchSplinter Review
Fixes two separate issues in gentransliterate.pl, and also includes changes from attachment 144882 [details] [diff] [review] from bug 238844 to exclude comments from the generated file (which I thought had landed years ago).
Attachment #229648 - Flags: superreview?
Attachment #229648 - Flags: review?(jshin1987)
Attachment #229648 - Flags: superreview? → superreview?(rbs)
Comment on attachment 229648 [details] [diff] [review]
Patch

r=jshin
Attachment #229648 - Flags: review?(jshin1987) → review+
Comment on attachment 229648 [details] [diff] [review]
Patch

sr=rbs
Attachment #229648 - Flags: superreview?(rbs) → superreview+
Checked in.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 229648 [details] [diff] [review]
Patch

Bug 345156 has approval1.8.1, and it doesn't make much sense to merge it back to exclude this rather trivial fix.
Attachment #229648 - Flags: approval1.8.1?
Comment on attachment 229648 [details] [diff] [review]
Patch

a=beltzner on behalf of drivers for the mozilla_1_8_branch
Attachment #229648 - Flags: approval1.8.1? → approval1.8.1+
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.