345051 - DOS line endings were checked into nsSVGGlyphFrame.h rev 1.9

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Please be very careful not to do this.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Robert Longson [:longsonr]]

Sorry about that.

Comment 3

[Jonathan Watt [:jwatt]]

No worries. I've done it myself. :-)

Comment 4

[tor]

Something is odd about the way that nsSVGTextContainerFrame.{h,cpp} and nsSVGTextFrame.h were added - they checkout with the execute bit set.

Comment 5

[Robert Longson [:longsonr]]

I think they are the only files I've added. I just did a cvs add and a cvs commit.  I'm using cygwin cvs.

Comment 6

[Robert Longson [:longsonr]]

Attachment: patch for cpp

I managed to do the same thing in a couple of lines in nsSVGGlyphFrame.cpp too.

Comment 7

[Robert Longson [:longsonr]]

Attachment: updated patch

also nsISVGGlyphFragmentLeaf.h :-(

Comment 8

[Robert Longson [:longsonr]]

updated patch checked in.

Comment 9

[Martijn Wargers (dead)]

Patches are checked in, so is this bug fixed now? I mean it should be marked fixed now, not?

Comment 10

[Jonathan Watt [:jwatt]]

yup