js/src/config/WINNT*.mk has incorrect flags for debug shell builds

RESOLVED INVALID

Status

()

Core
JavaScript Engine
RESOLVED INVALID
12 years ago
11 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
WINNT5.x contains

# MSVC compiler options for debug builds linked to MSVCRTD.DLL
# -MDd     - link with MSVCRTD.LIB (Dynamically-linked, multi-threaded, debug C-runtime)
# -Od      - minimal optimization
WIN_IDG_CFLAGS = -MDd -Od -Z7 

# MSVC compiler options for debug builds linked to MSVCRT.DLL
# -MD      - link with MSVCRT.LIB (Dynamically-linked, multi-threaded, debug C-runtime)
# -Od      - minimal optimization
WIN_DEBUG_CFLAGS = -MD -Od -Zi -Fd$(OBJDIR)/$(PDBFILE)
                  ^^^^^

should be -MDd to properly include the debug version of MSVCRTD.DLL
(Assignee)

Comment 1

12 years ago
Created attachment 229716 [details] [diff] [review]
patch v1

I ran tests using jsDriver.pl using debug shell builds on windows xp with this configuration, but I'm not entirely certain the proper return codes were set for crashes.
Attachment #229716 - Flags: review?(timeless)

Comment 2

12 years ago
Comment on attachment 229716 [details] [diff] [review]
patch v1

no. read the comment. it explicitly wants to link to msvcrt.dll

# MSVC compiler options for debug builds linked to MSVCRT.DLL
Attachment #229716 - Flags: review?(timeless) → review+

Comment 3

12 years ago
Comment on attachment 229716 [details] [diff] [review]
patch v1

no. read the comment. it explicitly wants to link to msvcrt.dll

# MSVC compiler options for debug builds linked to MSVCRT.DLL
Attachment #229716 - Flags: review+ → review-

Comment 4

12 years ago
(I don't like flags, way too easy for me to make a big mistake :()
(Assignee)

Comment 5

12 years ago
(In reply to comment #4)
> (I don't like flags, way too easy for me to make a big mistake :()
> 

Heh, yeah, I didn't get the r+ with no. 

Ok, so is this bug invalid then? Why does it want to link to the non-debug version of the crt?

Comment 6

11 years ago
the goal would to be able to ship it presumably. you're not really allowed to ship things that depend on the debug crt (read the license).
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → INVALID
(Assignee)

Comment 7

11 years ago
The goal is to test it.
You need to log in before you can comment on or make changes to this bug.