345114 - Center the "Live Titles" separator in the bookmark name picker

Status: VERIFIED WONTFIX

(Firefox Graveyard :: Microsummaries, defect)

Description

[Simon Bünzli]

... because IMO it looks cleaner.

Comment 1

[Simon Bünzli]

Attachment: screenshot showing the difference

Comment 2

[Simon Bünzli]

Attachment: fix

Simply add a second menuseparator to level out the first one.

BTW: Is it intentional that we use two different entities for the "Live Titles" string?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 229721 [details] [diff] [review]
fix

The drop-down menu, and the position of the "Live Titles" label within it, were beltzner's ideas.  Mike, what say you?

> BTW: Is it intentional that we use two different entities for the "Live Titles"
> string?

Yeah, unfortunately addBookmarks2.xul and bookmarksProperties.xul use different localization DTDs with different naming schemes.  For consistency with the code around it, I made the microsummary fields use the same files/naming schemes.

Places unifies these dialogs, however, so that problem will be going away.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 229721 [details] [diff] [review]
fix

The right-alignment was indeed on purpose to also mimic the right-alignment of the search suggestions "suggestions" label.

(Also, stronger alignment is generally more pleasing to the eye (and certainly less attention-grabbing) than weaker alignment.)

Comment 5

[Simon Bünzli]

I'm not too fond of how the text aligns to an invisible border, but I see your point. Never mind.