Closed
Bug 345114
Opened 19 years ago
Closed 19 years ago
Center the "Live Titles" separator in the bookmark name picker
Categories
(Firefox Graveyard :: Microsummaries, defect)
Firefox Graveyard
Microsummaries
Tracking
(Not tracked)
VERIFIED
WONTFIX
People
(Reporter: zeniko, Unassigned)
Details
Attachments
(2 files)
|
18.14 KB,
image/png
|
Details | |
|
2.51 KB,
patch
|
beltzner
:
ui-review-
|
Details | Diff | Splinter Review |
... because IMO it looks cleaner.
| Reporter | ||
Comment 1•19 years ago
|
||
| Reporter | ||
Comment 2•19 years ago
|
||
Simply add a second menuseparator to level out the first one.
BTW: Is it intentional that we use two different entities for the "Live Titles" string?
Comment 3•19 years ago
|
||
Comment on attachment 229721 [details] [diff] [review]
fix
The drop-down menu, and the position of the "Live Titles" label within it, were beltzner's ideas. Mike, what say you?
> BTW: Is it intentional that we use two different entities for the "Live Titles"
> string?
Yeah, unfortunately addBookmarks2.xul and bookmarksProperties.xul use different localization DTDs with different naming schemes. For consistency with the code around it, I made the microsummary fields use the same files/naming schemes.
Places unifies these dialogs, however, so that problem will be going away.
Attachment #229721 -
Flags: ui-review?(beltzner)
Comment 4•19 years ago
|
||
Comment on attachment 229721 [details] [diff] [review]
fix
The right-alignment was indeed on purpose to also mimic the right-alignment of the search suggestions "suggestions" label.
(Also, stronger alignment is generally more pleasing to the eye (and certainly less attention-grabbing) than weaker alignment.)
Attachment #229721 -
Flags: ui-review?(beltzner) → ui-review-
| Reporter | ||
Comment 5•19 years ago
|
||
I'm not too fond of how the text aligns to an invisible border, but I see your point. Never mind.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → WONTFIX
| Reporter | ||
Updated•19 years ago
|
Attachment #229721 -
Flags: review?(myk)
| Reporter | ||
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
| Reporter | ||
Updated•17 years ago
|
Assignee: zeniko → nobody
| Assignee | ||
Updated•10 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•