345159 - Print/Preview crash with null root content [@ nsINode::IsInDoc] from [@ nsPrintEngine::MapContentToWebShells]

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Mats Palmgren (inactive)]

Print/Preview crash with null root content [@ nsINode::IsInDoc] from [@ nsPrintEngine::MapContentToWebShells]

STEPS TO REPRODUCE
1. load the attached testcase
2. click on the button
3. select File->Print Preview  => CRASH

PLATFORMS AND BUILDS TESTED
Bug occurs with SeaMonkey trunk debug build on Linux

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 2

[Mats Palmgren (inactive)]

Attachment: stack

Comment 3

[Leon Sha]

document.removeChild(document.getElementsByTagName("*")[0])
This line remove the root content.

Comment 4

[Bernd]

this also affects branches like Gecko/20060516 SeaMonkey/1.0.2

Comment 5

[Leon Sha]

I have checked this page with IE.
What IE do is to save this page to local and print.
So a blank page will be printed.
So what we should do here?
The most easy way is to give out an error when there is no rootcontent.

Comment 6

[Mats Palmgren (inactive)]

Attachment: Testcase #2, sub-document without root content

Comment 7

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

This patch makes us avoid sub-documents that does not have root content (but
prints everything else). If the root document does not have content an error
dialog is displayed. I re-used the following message:
"Printing failed when starting the document."
(I don't think it's worth the bloat to have a specific message for this
rather extreme edge case).

Comment 8

[Boris Zbarsky [:bzbarsky]]

So.. Shouldn't we call CleanupOnFailure() instead of manually calling ShowPrintErrorDialog?  I know the existing error handling is inconsistent; just not sure why... :(

Comment 9

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Using CleanupOnFailure()

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 230418 [details] [diff] [review]
Patch rev. 2

Looks great.  r+sr=bzbarsky

Comment 11

[Mats Palmgren (inactive)]

Checked in to trunk at 2006-07-25 09:05 PDT.

-> FIXED

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Although I get a "Printing failed when starting the document" error message when print previewing after clicking the button in https://bugzilla.mozilla.org/attachment.cgi?id=229787&action=view, neither it nor https://bugzilla.mozilla.org/attachment.cgi?id=230110&action=view crash any longer.

(I think the error is valid--content has been removed--but what a generic error message; I'll have to see if there's a bug filed to make it nicer.)

Verified FIXED using build 2006-07-27-09 of SeaMonkey trunk under Windows XP.