no tooltip for bookmarks overflow chevron button

VERIFIED FIXED in Firefox 3.6a1



Bookmarks & History
12 years ago
9 years ago


(Reporter: (not reading, please use instead), Assigned: Andreas Wuest)


({late-l10n, polish, verified1.9.1})

Firefox 3.6a1
late-l10n, polish, verified1.9.1

Firefox Tracking Flags

(Not tracked)



(1 attachment, 1 obsolete attachment)

no tooltip for bookmarks overflow chevron

beltzner, do you think we need one?

I'm using 2.0 b1 official bits on winxp.
fwiw, safari has "Show more bookmarks."
beltzner suggests:  "Show more bookmarks" (note safari does "Show more bookmarks.")

Comment 3

10 years ago
Created attachment 308258 [details] [diff] [review]

Shows a "Show more bookmarks" tooltip when hovering over the chevron. Makes sure that menuitems contained in the chevron's menu don't inherit the chevron's tooltiptext.
Attachment #308258 - Flags: review?(seth)

Comment 4

10 years ago
Comment on attachment 308258 [details] [diff] [review]

forwarding review to gavin.
Attachment #308258 - Flags: review?(seth) → review?(
Component: Bookmarks → Places
OS: Windows XP → All
QA Contact: bookmarks → places
Hardware: PC → All
Comment on attachment 308258 [details] [diff] [review]

This looks fine for me, though we're past string freeze so we're unlikely to be able to take this for Firefox 3.
Attachment #308258 - Flags: review?( → review?(mano)
Assignee: nobody → awuest
Summary: no tooltip for bookmarks overflow chevron → no tooltip for bookmarks overflow chevron button

Comment 6

10 years ago
Should this bug have [polish-interactive] and [polish-easy] set?
Created attachment 352897 [details] [diff] [review]
updated patch

The patch for bug 237592 made the tooltiptext="" part unnecessary.
Keywords: checkin-needed
Attachment #308258 - Attachment is obsolete: true
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Comment on attachment 352897 [details] [diff] [review]
updated patch

asking approval for 1.9.1, no risk.
Attachment #352897 - Flags: approval1.9.1?
Comment on attachment 352897 [details] [diff] [review]
updated patch

a191=beltzner; no risk, but text change which needs to land before Dec 31 to meet string freeze
Attachment #352897 - Flags: approval1.9.1? → approval1.9.1+
Keywords: late-l10n, polish

Comment 13

9 years ago

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1b3pre) Gecko/20090130 Shiretoko/3.1b3pre
Keywords: fixed1.9.1 → verified1.9.1
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.