345216 - Prevent evasion of NS_EARLYFORMSUBMIT_SUBJECT

Status: NEW

(Core :: Layout: Form Controls, defect)

Description

[Michael Wu [:mwu]]

It is possible, though unlikely, that a page can prevent the NS_EARLYFORMSUBMIT_SUBJECT notification on submit by:

1. Using an ordinary enter/button click to submit the form
2. Setting the action in the page's js submit handler and canceling the submit.
3. Trying to submit via submit(). (ordinary enters/clicks on submit button still work correctly)

The chances of everything happening like this are pretty slim, but this should be fixed anyway. The submit() code needs to reset the early notification bit (when a submit is not currently in progress).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Need a better understand of what problems this actually causes / could cause in order to accept for [wanted-1.9] or blocking1.9+.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The problems it would cause would be with the Firefox form/password manager.  It would store the wrong data (or possibly nothing).