345224 - datepicker ally issues

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[alexander :surkov (:asurkov)]

datepicker should be consistent with http://www.mozilla.org/access/toolkit-checklist ("Lists and combo boxes section").

Comment 1

[alexander :surkov (:asurkov)]

html datepicker:
1) when calendar is closed by escape then focus doesn't return to input field
2) pressing alt+up/alt+down makes window to forward/back

xul datepicker:
1) when calendar is closed then focus doesn't return to input field
2) F4, alt+down, alt+up does't toggle calendar
3) pressing alt+up/alt+down makes window to forward/back

If we should act like comboboxes then I guess focus should be always in input field, there we should handle navigation keys and forward them into calendar. If we're typing date into input field then calendar should show typing date. Right?

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

Patch is addressed to:

> html datepicker:
> 1) when calendar is closed by escape then focus doesn't return to input field
> 2) pressing alt+up/alt+down makes window to forward/back
> 
> xul datepicker:
> 2) F4, alt+down, alt+up does't toggle calendar
> 3) pressing alt+up/alt+down makes window to forward/back

Comment 3

[aaronr]

checked into trunk for surkov.  Leaving bug open at his request.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #1)

> If we should act like comboboxes then I guess focus should be always in input
> field, there we should handle navigation keys and forward them into calendar.
> If we're typing date into input field then calendar should show typing date.
> Right?
> 

AaronLev, am I right?

Comment 5

[Aaron Leventhal]

Right, the DOM focus events should be on the main datepicker element, but the accessible focus events we fire from nsRootAccessible::HandleEventWithTarget() should be on any child element in the dropdown that becomes active. Your impl could fire a custom DOM event that nsRootAccessible maps to the accessible focus events.

Also any time the value in the input field changes you should fire a custom ValueChange DOM event for it. That will cause the nsRootAccessible::HandleEventWithTarget() method to map that to accessible value change events.

Comment 6

[alexander :surkov (:asurkov)]

I filed new bug 348690 about focus issues for datepicker. Marking this one as fixed.

Comment 7

[aaronr]

checked into 1.8.0 branch on 2006/09/21

Comment 8

[aaronr]

checked into 1.8 branch on 2006/11/21