345244 - Bug template creation window has silly title

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Fergus Sullivan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4

on bugzilla-tip 

Reproducible: Always

Steps to Reproduce:
1. Open a new bug entry page.
2. Click on button [Remember values as bookmarkable template]


Actual Results:  
Resulting page title is "Bookmarks are your friend"

Expected Results:  
Use a more sensible title, maybe "Bookmark ready to be added to your browser"

This page also uses curly quotes rather than straight quotes.

See also bug 345241 for a broader problem with this page.

Comment 1

[Max Kanat-Alexander]

Yes, it does indeed have a silly title. :-) That's totally fine by me.

The only reason I'd think to change the title is if the title served some use or purpose. :-)

Personally, I'm quite fond of the silly title.

Comment 2

[Frédéric Buclin]

I'm not. Valid request.

Comment 3

[Max Kanat-Alexander]

Honestly, I saw it for the first time today, and it made me laugh. :-) Programming is a job often with little laughter, and it's nice to see something funny once in a while in an unexpected location.

Comment 4

[Sunil Joshi [:sjoshi]]

Not able to reproduce it against trunk.
It seems this also fixed, please mark it accordingly.

Comment 5

[Frédéric Buclin]

(In reply to Sunil Joshi from comment #4)
> Not able to reproduce it against trunk.
> It seems this also fixed, please mark it accordingly.

No, this is not fixed.

Comment 6

[Sunil Joshi [:sjoshi]]

Attachment: Patch

Comment 7

[Frédéric Buclin]

Comment on attachment 661839 [details] [diff] [review]
Patch

Looks good. r=LpSolit

Comment 8

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/bug/create/make-template.html.tmpl
Committed revision 8396.