34526 - Replace EdMessage.xul usage with AlertWithTitle method

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Fredrik Sundberg]

Two Netscape titled alerts are shown when attempting to do something forbidden 
in the Named Anchor dialog.

1. Launch Editor
2. Click on the 'Anchor' icon
3. Click OK -->"You must enter a name for this dialog" comes up, and the title 
is Netscape and should not be so in Mozilla.

...or...
3. Name it "X" and click OK
4. Relaunch the dialog by clicking the 'Anchor' icon
5. Name it "X" and click OK -->"X already exists in this page. Please enter a 
different name" comes up, and the title is Netscape and should not be so in 
Mozilla.

Comment 1

[Fredrik Sundberg]

Attachment: Patch for the problem

Comment 2

[rubydoo123]

assigning to Kathy and setting to M16

Comment 3

[rubydoo123]

assigning to brade

Comment 4

[Kathleen :Brade]

The real problem is that EdMessage.xul has hardcoded the string "Netscape"

Comment 5

[Charles Manske]

I'll take this. EdMessage.xul is going away, there's a new editor shell 
method to use the common "Alert" dialog: editorShell.AlertWithTitle(title,
message) that we should use for simple message purposes. I plan to do all the
required replacements when I rewrite all the dialogs. The title should be 
neither "Netscape" nor "Mozilla", but something that indicates the context
of the message.
Kathy: Be sure to use "ValidateNumberString()" for range validation in the 
image dialog (an any others that you happen to be working on.) This uses the 
new alert dialog.

Comment 6

[Fredrik Sundberg]

Good, and the title of these messages needs to be localizable.
/Fredrik 

Comment 7

[Charles Manske]

Of course. Any string you use should be retrieved from the editor.properties
string bundle file like this:
editorShell.AlertWithTitle(GetString("titleID"),GetString("msgID"));
(you can use editorShell.GetString, but there's a JS helper in EdDialogCommon.js
to make it easier.)

Comment 8

[Charles Manske]

Part of skins rewrite. (Already fixed in my tree)

Comment 9

[rubydoo123]

updating keyword and status whiteboard to reflect that this is a beta 2 feature 
work bug that the Composer team deems a must fix for beta 2.

Comment 10

[Charles Manske]

For a simple messagebox, we should use AlertWithTitle() method instead of 
the EdMessage.xul dialog.
Verification is that all simple "messagebox" dialogs should look the same and 
have the "information" icon on the left. The title should not be "Netscape"
or "Mozilla", but a title specific to the context of the message.

Comment 11

[sujay]

verified in 5/12 build.