Closed
Bug 345277
Opened 18 years ago
Closed 18 years ago
When "Certificate Viewer" is shut, the object leaks
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
VERIFIED
FIXED
People
(Reporter: sugar.waffle, Assigned: KaiE)
References
()
Details
(Keywords: memory-leak, verified1.8.1.2)
Attachments
(1 file)
562 bytes,
patch
|
rrelyea
:
review+
jay
:
approval1.8.1.2+
|
Details | Diff | Splinter Review |
Reproducible: Always Steps to Reproduce: 1. Open URL 2. Open Tool --> Page Info 3. Click Security tab 4. Click View button 5. Click Close button on Certifitate Viewer Leak Monitor report: Leaks in window 0x2498460: [ ] [leaked object] (2613a18) = [object Object] [ ] [leaked object] (2613a18) = [object Object] Windows XP SP1 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060719 Minefield/3.0a1
Comment 1•18 years ago
|
||
I just stumbled this too. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060904 Minefield/3.0a1 ID:2006090404 [cairo]
Comment 2•18 years ago
|
||
I think it's leaking its listener callback object somehow. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/manager/pki/resources/content/viewCertDetails.js&rev=1.29#195
Assignee: nobody → kengert
Component: General → Security: PSM
OS: Windows XP → All
Product: Firefox → Core
QA Contact: general
Hardware: PC → All
Assignee | ||
Comment 3•18 years ago
|
||
Good catch! I think nsBaseVerificationJob needs a virtual destructor.
Assignee | ||
Comment 4•18 years ago
|
||
I confirm, with our existing code, the destructors of our cert verification jobs never get called, resulting in leaks!!! Adding a virtual constructor to the common base class of all such jobs is sufficient. In my testing, this caused the destructors of the derived classes to get called, at the time the verification thread deletes the job via its base pointer.
Attachment #240261 -
Flags: review?(rrelyea)
Comment 5•18 years ago
|
||
*** Bug 354507 has been marked as a duplicate of this bug. ***
Comment 6•18 years ago
|
||
*** Bug 354646 has been marked as a duplicate of this bug. ***
Comment 7•18 years ago
|
||
Kaie, what was the original class that was leaking? bob
Assignee | ||
Comment 8•18 years ago
|
||
(In reply to comment #7) > Kaie, what was the original class that was leaking? The classes that leak are the ones derived from the base nsBaseVerificationJob: - nsCertVerificationJob - nsSMimeVerificationJob In order to clean up correctly, the destructors of those function must get called. But currently they never get called. Because we delete the base class pointer.
Comment 9•18 years ago
|
||
Comment on attachment 240261 [details] [diff] [review] Patch v1 r+= rrelyea
Attachment #240261 -
Flags: review?(rrelyea) → review+
Assignee | ||
Comment 10•18 years ago
|
||
fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•18 years ago
|
||
Comment on attachment 240261 [details] [diff] [review] Patch v1 I propose to check in this correctness fix to the 1.8 branch.
Attachment #240261 -
Flags: approval1.8.1.2?
Attachment #240261 -
Flags: approval1.8.1.1?
Comment 12•18 years ago
|
||
*** Bug 363369 has been marked as a duplicate of this bug. ***
Comment 13•18 years ago
|
||
(In reply to comment #12) > *** Bug 363369 has been marked as a duplicate of this bug. *** > hi, when will we (end users) see this fix? just asking for a time+version estimate -thanks
Updated•18 years ago
|
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.2?
Updated•18 years ago
|
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.2?
Flags: blocking1.8.1.2+
Comment 14•18 years ago
|
||
Comment on attachment 240261 [details] [diff] [review] Patch v1 Approved for 1.8 branch, a=jay for drivers.
Attachment #240261 -
Flags: approval1.8.1.2?
Attachment #240261 -
Flags: approval1.8.1.2+
Attachment #240261 -
Flags: approval1.8.1.1?
Assignee | ||
Comment 15•18 years ago
|
||
Checked in to 1.8 branch. Checking in nsVerificationJob.h; /cvsroot/mozilla/security/manager/ssl/src/nsVerificationJob.h,v <-- nsVerificationJob.h new revision: 1.1.2.3; previous revision: 1.1.2.2 done
Keywords: fixed1.8.1.2
Comment 16•18 years ago
|
||
Verified Fixed for 1.8.1.2 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/2007011004 BonEcho/2.0.0.2pre on Windows x64 and on Linux Fedora FC6
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.2 → verified1.8.1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•