345343 - "All Tabs" button shows as active when hovered over after selecting a tab

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060720 Minefield/3.0a1

Steps to reproduce:
1. Open up a few tabs so you see the All Tabs button.
2. Click the button and select a tab from the list.
3. Hover over the button.

Results:
Button is shown as active when hovered.

Expected results:
Button looks like it's being hovered.

Comment 1

[Nir]

Confirmed, I also have faced same in fedora core 5 .
Using FF 3.0a1

Comment 2

[Adam Guthrie]

*** Bug 345429 has been marked as a duplicate of this bug. ***

Comment 3

[(not reading, please use [e-mail] instead)]

> Wait, doesn't this happen because you are using the same image in the :hover
> case (in winstripe)?

yes, thanks for catching that.  I have a fix for that (I'll attach).

as noted in #345429, there are two issues.

1)  need to use the right image on hover:active
2)  button border appears active when hovered (after following adam's steps)

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: fix for active:hover state (thanks adam / asaf)

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> Created an attachment (id=230174) [edit]
> fix for active:hover state (thanks adam / asaf)
> 

 .tabs-alltabs-button:hover {
   -moz-image-region: rect(0px, 48px, 16px, 32px);
 }
 
+.tabs-alltabs-button:hover:active {
+  -moz-image-region: rect(0px, 64px, 16px, 48px);
+}
+

you're still 16px off ...
16-32px = hover
32-48px = active
48-64px = disabled

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #3)
> 2)  button border appears active when hovered (after following adam's steps)

When addressing this, maybe you could also fix that the button is not in active state while the menu is open. Or should I file a separate bug for that?

Comment 7

[Asaf Romano (gone)]

Comment on attachment 230174 [details] [diff] [review]
fix for active:hover state (thanks adam / asaf)

per comments

Comment 8

[Adam Guthrie]

(In reply to comment #6)
> When addressing this, maybe you could also fix that the button is not in active
> state while the menu is open. Or should I file a separate bug for that?

The Back/Forward menu shows as hovered when you open it and hover entries in the list, so Seth and I figured this is the correct behavior.

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #8)
> The Back/Forward menu shows as hovered when you open it and hover entries in
> the list, so Seth and I figured this is the correct behavior.

That's contrary to the Search Engine drop down menu.

However, we have also a semantic difference here. 'hover' implies that the button can still be clicked, which could be valid for Back/Forward (I cannot check this right now, because I've removed the dropmarker). But here it makes hardly sense. When the menu is open, the sole purpose of the button is being served, so it should be 'active'.

Comment 10

[Adam Guthrie]

OK that makes sense, Dao.

Comment 11

[Adam Guthrie]

*** Bug 350706 has been marked as a duplicate of this bug. ***

Comment 12

[(not reading, please use [e-mail] instead)]

sorry for the bug spam, re-assigning bugs back to default owner if I'm not working actively on them.