Closed
Bug 345359
Opened 20 years ago
Closed 20 years ago
Prevent Flag::clear from deleting a deleted flag when checking the inclusion and exclusion lists
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
Attachments
(1 file)
|
2.31 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Because the SQL queries about the inclusion and exclusion lists use SELECT flags.id instead of SELECT DISTINCT flags.id, it's possible under some circumstances to get twice the same flag ID. And the clear() will try to delete a flag which has already been deleted. It may end in a crash.
|
Assignee | |
Comment 1•20 years ago
|
||
Make sure to not have twice the same flag ID in the list.
Attachment #229991 -
Flags: review?(myk)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Flags: approval?
|
||
Updated•20 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 2•20 years ago
|
||
Comment on attachment 229991 [details] [diff] [review]
patch, v1
no review needed
Attachment #229991 -
Flags: review?(myk)
|
|
Assignee | |
Comment 3•20 years ago
|
||
Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v <-- editflagtypes.cgi
new revision: 1.42; previous revision: 1.41
done
Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v <-- Flag.pm
new revision: 1.70; previous revision: 1.69
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•20 years ago
|
Attachment #229991 -
Flags: review+
You need to log in
before you can comment on or make changes to this bug.
Description
•