345400 - Password manager can't handle case insensitive user field names imported from IE

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Michael Wu [:mwu]]

Our username field matching is case sensitive. IE's password manager saves its username fields as lowercase. Thus, sites like bugzilla which have uppercase characters in the field name cannot use logins imported from IE.

Comment 1

[Michael Wu [:mwu]]

Attachment: Handle passwords imported from IE better

This patch detects IE passwords by checking for an empty password field name if the username field does not match. It then does a case insensitive search for the username field and updates that if located. It also updates the password field after locating that. The signon updates do not save at this point merely because they are used to prevent the password manager from prompting the user if he/she wishes to save the password later in Notify().

Comment 2

[Neil Deakin]

Comment on attachment 230060 [details] [diff] [review]
Handle passwords imported from IE better

>+        if ((e->passField).IsEmpty())
>+          passField->GetName(e->passField);

Does this change the stored password field name and save it?

Patch looks OK

Comment 3

[Michael Wu [:mwu]]

(In reply to comment #2)
> Does this change the stored password field name and save it?
> 
It updates the password field name in memory but it doesn't save it to disk until the user decides to submit the form. The updating is primarily done to avoid asking the user if he/she wishes to save the password later.

Comment 4

[Martijn Wargers (dead)]

Checking in nsPasswordManager.cpp;
/cvsroot/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,v  <-
-  nsPasswordManager.cpp
new revision: 1.84; previous revision: 1.83
done

Checked into trunk.

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 230060 [details] [diff] [review]
Handle passwords imported from IE better

This patch adds code that handles a condition which we couldn't handle before. It should be fairly safe to put on branch.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230060 [details] [diff] [review]
Handle passwords imported from IE better

a=drivers. Please land on MOZILLA_1_8_BRANCH.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp 	1.65.2.9