Help Window Icon Replacement

RESOLVED FIXED in Firefox 2 beta2

Status

()

Firefox
General
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Michael Glenn, Assigned: Jay Goldman)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 beta2
fixed1.8.1
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx2 theme change], URL)

Attachments

(4 attachments, 3 obsolete attachments)

(Reporter)

Description

12 years ago
Update of the icon set for the help window.
Flags: blocking-firefox2+

Updated

12 years ago
Status: NEW → ASSIGNED
Whiteboard: [Fx2 theme change]
*** Bug 347920 has been marked as a duplicate of this bug. ***
(Assignee)

Updated

12 years ago
Assignee: mglenn → jgoldman
Status: ASSIGNED → NEW
(Assignee)

Comment 2

12 years ago
Created attachment 233933 [details] [diff] [review]
Pinstripe image replacements patch

Requires the pinstripe-help-images.zip, which follows.
Attachment #233933 - Flags: review?(mconnor)
(Assignee)

Comment 3

12 years ago
Created attachment 233934 [details]
Pinstripe image replacements

Requires the previously uploaded help-icons.diff for Pinstripe
Looks fine here on my Mac.
(Assignee)

Comment 5

12 years ago
Created attachment 233954 [details] [diff] [review]
Pinstripe image replacements patch v2

Replaces the previous patch. This connects the dropmarks with the Back/Forward buttons as per the Main Window toolbar. There's still a problem with this patch as the Home and Print buttons shrink by 2 px when you hover which causes them to shift.
Attachment #233933 - Attachment is obsolete: true
Attachment #233933 - Flags: review?(mconnor)
(Assignee)

Comment 6

12 years ago
Created attachment 233956 [details]
Pinstripe image replacements v2
Attachment #233934 - Attachment is obsolete: true
Where are the Winstripe bits? :)
(Assignee)

Comment 8

12 years ago
Created attachment 234153 [details]
Winstripe Image Replacements

Requires the forthcoming winstripe patch file.
(Assignee)

Comment 9

12 years ago
Created attachment 234160 [details] [diff] [review]
Pinstripe image replacements patch v3

All known issues are resolved with this patch. Requires the pinstripe v3 images.zip.
Attachment #233954 - Attachment is obsolete: true
Attachment #234160 - Flags: review?(mconnor)
(Assignee)

Comment 10

12 years ago
Created attachment 234162 [details] [diff] [review]
Winstripe image replacement patch
Attachment #234162 - Flags: review?(mconnor)
Comment on attachment 234160 [details] [diff] [review]
Pinstripe image replacements patch v3

looks great
Attachment #234160 - Flags: review?(mconnor)
Attachment #234160 - Flags: review+
Attachment #234160 - Flags: approval1.8.1+
Comment on attachment 234162 [details] [diff] [review]
Winstripe image replacement patch

this needed a couple extra lines to suppress some of the restored hover styles

will fix on checkin, otherwise looks good!
Attachment #234162 - Flags: review?(mconnor)
Attachment #234162 - Flags: review+
Attachment #234162 - Flags: approval1.8.1+
landed on branch!
Keywords: fixed1.8.1
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.