Closed Bug 345491 Opened 18 years ago Closed 18 years ago

Editing recurring event shows 'All' vs. 'This occurrence' dialog twice

Categories

(Calendar :: Calendar Frontend, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: jminta)

Details

Attachments

(1 file)

Editing recurring event shows 'All' vs. 'This occurrence' dialog twice

Steps to Reproduce:
1. Start Sunbird with clean profile
2. Create recurring event
3. Double click recurring event to open Edit Dialog

Actual Results: 
'All' vs. 'This occurrence' dialog is shown twice. 
(Except you press cancel of course)

Expected Results:
'All' vs. 'This occurrence' dialog is shown only once.

Additional Information:
If I select 'Edit' from toolbar or context menu the dialog is shown once.

Works in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/2006072007 Calendar/0.3a2+

Fails in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/2006072108 Calendar/0.3a2+
Attached patch forked code sucks — — Splinter Review
Forked code really, really sucks.  editEvent() will cause the prompt to fire, so we need to make sure we don't call getParentorOccurrence before it.  What we really need to do is unify selection, so we can always pass the correct item into modifyEventWithDialog.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #230393 - Flags: first-review?(dmose)
Comment on attachment 230393 [details] [diff] [review]
forked code sucks

r=dmose
Attachment #230393 - Flags: first-review?(dmose) → first-review+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Verified with Sunbird/0.3a2+ (2006080207).
Verified with Thunderbird 1.5.0.5 (20060719) + Lightning/0.1+ (2006080207).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: