345542 - Use of let in let-scoped for loops shows assertion

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[nanto_vi (TOYAMA Nao)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4

An assertion is shown when using let statements/expressions/declarations in let-scoped for/for...in/for-each...in loops and repeating more than one time.

Reproducible: Always

Steps to Reproduce:
js> var f = [];
js> for (let i = 0; i < 1; i++) f[i] = let (n = i) function () { return n; };
function () {
    return n;
}
js> for (let i = 0; i < 2; i++) f[i] = let (n = i) function () { return n; };


Actual Results:  
Assertion failure: OBJ_GET_PARENT(cx, obj) == fp->blockChain, at jsinterp.c:5959

Expected Results:  
No assetion is shown.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Yes, quite. Patch forthcoming.

Nanto, so you know, we've given you canconfirm bugzilla privileges so you can start filing these bugs as NEW instead of UNCONFIRMED. These reports are really appreciated.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

The first time we went around the while loop, we captured the scope chain, so blockChain was null'd out. Brendan and I went through all of the uses of fp->blockChain and determined that this was actually the right "fix".

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 230222 [details] [diff] [review]
Fix

Assertion-only fix, should be automatically approved.

/be

Comment 5

[Bob Clary [:bc] (inactive)]

Checking in regress-345542.js;
/cvsroot/mozilla/js/tests/js1_7/block/regress-345542.js,v  <--  regress-345542.js
initial revision: 1.1

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230222 [details] [diff] [review]
Fix

a=drivers. Automatic approval given. :)

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed trunk 20060723 win/mac*/linux

mrbkap: Can you check this into 1.8 today? Thanks.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into the 1.8 branch.

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.1 windows/mac(ppc|tel)/linux 20060728