345561 - why try / catch in adjustTabstrip() in tabbrowser.xml?

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(not reading, please use [e-mail] instead)]

why try / catch in adjustTabstrip() in tabbrowser.xml?

we're not sure why, which is why we added the "XXXzeniko" comment:

           case 1:
             try {
...
             }
             catch (e) {
               // XXXzeniko what error are we catching here?
             }

Comment 1

[Michael Ventnor]

Attachment: Remove try clause

All it is is just setting an attribute, the same in all other cases. I don't see the need for a try clause either.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Getting the boxObject property can apparently sometimes fail, perhaps that was an issue at some point?

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/xul/content/src/nsXULElement.cpp&rev=1.644#2036
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/base/src/nsDocument.cpp&rev=3.667#3215

Comment 3

[Mike Connor [:mconnor]]

hmm, maybe I hit this sometimes before the boxObject was defined?  I wrote most of this months ago...

I'd say try the patch on trunk, but not worth taking on branch unless the try/catch is deemed harmful.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 230237 [details] [diff] [review]
Remove try clause

sspitzer is busy with Places.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/tabbrowser.xml 	1.228