345568 - 'Undo Close Tab' should be on the History menu (alongside 'Recently Closed Tabs')

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, enhancement)

Description

[tommyjb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060721 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060721 BonEcho/2.0b1

[This might sound like a dupe of bug 342700, but I don't believe it is (correct me if I'm wrong).  As far as I can tell, that bug's about adding 'Recently Closed Tabs' to the main menu -- while this is about adding 'Undo Close Tab'.]

'Undo Close Tab' should be added to the history menu, above 'Recently Closed Tabs'.  Rationale:

1. This would make the keyboard shortcut more discoverable (see bug 344736).
2. It's inconsistent UI to have 'Undo Close Tab' on the tab-bar context menu only, which I believe is the case currently.
3. When the tab bar is hidden, there's no way of accessing 'Undo Close Tab'.  'Recently Closed Tabs' is accessible, sure, but that's less convenient (requires navigating an extra sub-menu and, often, making a choice between multiple items).

Reproducible: Always

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

The other option would be to simply add the keyboard shortcut to the first item in the Recently Closed Tabs list, since that's the one that will be opened with the command. This is precedented by the shortcuts in the flyout for the sidebar.

Comment 2

[Chris Ilias [:cilias]]

If this isn't a 'WONTFIX', I would consider putting it in the Edit menu, rather than the History menu. Or at maybe making Edit-->Undo take care of it.

Comment 3

[Jo Hermans]

related: bug 349076

Comment 4

[Dietrich Ayala (:dietrich)]

(In reply to comment #1)
> The other option would be to simply add the keyboard shortcut to the first item
> in the Recently Closed Tabs list, since that's the one that will be opened with
> the command. This is precedented by the shortcuts in the flyout for the
> sidebar.
> 

I filed the shortcut discoverability problem as bug 357235.

(In reply to comment #2)
> If this isn't a 'WONTFIX', I would consider putting it in the Edit menu, rather
> than the History menu. Or at maybe making Edit-->Undo take care of it.
> 

In the "undo close tab" bug, there's discussion about the de/merits of adding it to the undo stack, starting with this comment i believe: https://bugzilla.mozilla.org/show_bug.cgi?id=254021#c14