Page Setup window does not remember its last position when reopened

RESOLVED FIXED

Status

()

Core
Printing: Output
--
minor
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

({assertion})

Trunk
assertion
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

14.30 KB, text/plain
Details
3.10 KB, patch
mats
: review+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
Page Setup window does not remember its last position when reopened.

Also, the following assertion is occurs when opening the window:
###!!! ASSERTION: getElementById(""), fix caller?: '!aId.IsEmpty()', file nsXULDocument.cpp, line 1595

STEPS TO REPRODUCE
1. File -> Page Setup

BUILDS AND PLATFORMS TESTED
Bug occurs in SeaMonkey trunk debug build on Linux
Bug occurs in Firefox 2.0b1 on Linux
(Assignee)

Comment 1

12 years ago
Created attachment 230462 [details]
stack

This is the stack when the assertion occurs, the window is trying to
persist screenX/Y using id="" ...
(Assignee)

Comment 2

12 years ago
Created attachment 230463 [details] [diff] [review]
Patch rev. 1

This makes the window appear in its last position and does not trigger
the assertion.
Attachment #230463 - Flags: superreview?(neil)
Attachment #230463 - Flags: review?(neil)

Comment 3

12 years ago
Comment on attachment 230463 [details] [diff] [review]
Patch rev. 1

For some reason (I searched my disk and bugzilla and found nothing relevant) my local tree already has this file patched, but with an id of printPageSetupDialog, which I suggest is slightly more accurate ;-)
Attachment #230463 - Flags: superreview?(neil)
Attachment #230463 - Flags: superreview+
Attachment #230463 - Flags: review?(neil)
Attachment #230463 - Flags: review+
(Assignee)

Comment 4

12 years ago
Created attachment 230584 [details] [diff] [review]
Patch rev. 2

printPageSetupDialog it is...
Attachment #230463 - Attachment is obsolete: true
Attachment #230584 - Flags: superreview+
Attachment #230584 - Flags: review+
(Assignee)

Comment 5

12 years ago
Comment on attachment 230584 [details] [diff] [review]
Patch rev. 2

Checked in to trunk 2006-07-25 08:50 PDT.
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Blocks: 344397
You need to log in before you can comment on or make changes to this bug.