345828 - "WARNING: malformed hostname" when using keyword bookmark in address bar

Status: VERIFIED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Jesse Ruderman]

I'm using a Mac trunk debug build.

Steps to reproduce:
1. Type 'foo bar' into the address bar.

Result: a warning appears in the console as I type *each* letter of 'bar':

  WARNING: malformed hostname: file netwerk/base/src/nsURLParsers.cpp, line 580

Expected: no noise on the console.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Here's the stack to the warning:

necko.dll!nsAuthURLParser::ParseServerInfo()  Line 580	C++
necko.dll!nsAuthURLParser::ParseAuthority()  Line 518	C++
necko.dll!nsStandardURL::ParseURL()  Line 735	C++
necko.dll!nsStandardURL::SetSpec()  Line 1131	C++
necko.dll!nsStandardURL::Init()  Line 2587	C++
necko.dll!NewURI()  Line 132	C++
necko.dll!nsHttpHandler::NewURI()  Line 1422	C++
necko.dll!nsIOService::NewURI()  Line 484	C++
places.dll!NS_NewURI()  Line 123	C++
places.dll!NormalizeAutocompleteInput()  Line 683	C++
places.dll!nsNavHistory::AutoCompleteFullHistorySearch()  Line 426	C++
places.dll!nsNavHistory::StartSearch()  Line 335	C++

So this is a places bug.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #1)
> So this is a places bug.

... unless the idea is that ParseServerInfo (called by nsIIOService::newURI) shouldn't warn for malformed URIs. Jesse, what do you think?

Comment 3

[Jesse Ruderman]

That's roughly what I was thinking when I filed it on Networking.  Fixing this might require removing the warning from networking code, or providing a way to avoid the warning (such as a new function that doesn't warn).

Comment 4

[[:Aleksej]]

Is this not reproducible anymore?

Comment 5

[Dietrich Ayala (:dietrich)]

can't reproduce

Comment 6

[Jesse Ruderman]

I can't reproduce this any more either.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv