Closed Bug 345846 Opened 14 years ago Closed 12 years ago

cvs remove Linux installer files (installer.inc and browser/installer/unix except packages-static)

Categories

(Firefox :: Installer, defect)

x86
Linux
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3

People

(Reporter: Pike, Assigned: philor)

References

()

Details

Attachments

(2 files)

As we don't use installer.inc anymore, we should cvs remove it on trunk and 1.8 branch.
I would hope that since this was used by the xpinstall based installer that bug 344236 will take care of this.
Robert, that bug was fixed but installer.inc wasn't removed. 

It really needs to be removed as it is confusing (especially to localizers) and makes them waste their time for localizing a completely useless file.

Perhaps, we should even remove that from the 1.8 branch as well (and from all of the l10ns), so that new Firefox 2 locales don't get confused as well.
Benjamin, Robert, does one of you have cycles to clean up http://mxr.mozilla.org/mozilla/source/browser/installer/unix? I don't have a linux env set up myself, which would make testing a tad hard :-/.

Otherwise, we should mark this as a good first bug for build folks, I guess.
I think the only file used in browser/installer/unix is packages-static. We should remove the rest to stop people patching them unnecessarily.
Summary: cvs remove installer.inc → cvs remove Linux installer files (installer.inc and browser/installer/unix except packages-static)
Target Milestone: Firefox 2 beta2 → ---
Version: 2.0 Branch → Trunk
Depends on: 344236
Attached patch Remove itSplinter Review
Would have been more convenient if I'd run across this when it could have landed for 1.9, but I guess eventually I'll figure out when and how and where to check in for 2.0.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #313896 - Flags: review?(ted.mielczarek)
OS: All → Linux
Hardware: All → PC
Target Milestone: --- → Future
Phil, Ted, actually, this is npob, as far as I'm concerned, and if we make a good clean landing, we should be able to land this still.

Like, at least for the l10n part of this, I'd prefer to do this after freeze, but I wouldn't have a problem doing it then.

Not sure how Ted's review cycles are looking right now, though.
Comment on attachment 313896 [details] [diff] [review]
Remove it

Ditch it.
Attachment #313896 - Flags: review?(ted.mielczarek)
Attachment #313896 - Flags: review+
Attachment #313896 - Flags: approval1.9+
Phil, we should coordinate on the landing here, and announce it up-front in the newsgroup. Do you have a suggestion for a time to land this?
What about toolkit/installer/windows/install.it?
We settled on me landing en-US tonight, and Axel removing installer.inc and install.it for the other locales when he gets up (other than ones that even after seeing http://groups.google.com/group/mozilla.dev.l10n/browse_thread/thread/05d931b98229d7d6 decide not to wait for him and de-orange themselves).

Sorry about windows/install.it, but even though I'm certain it's unused, I'm not comfortable removing something in the final seconds before a freeze without any review or testing, when it wasn't even mentioned in the bug until after all the reviewing and approving was done. Filing bugs on all the horribly broken crap that you as a localizer see and hate all the time, but en-US-speaking developers never have any reason to notice, would be a wonderful help. Feel free to cc me on any of them, any product.
browser/makefiles.sh 1.6
browser/installer/unix/.cvsignore delete
browser/installer/unix/Makefile.in delete
browser/installer/unix/ab-CD.jst delete
browser/installer/unix/abe.jst delete
browser/installer/unix/adt.jst delete
browser/installer/unix/browser.jst delete
browser/installer/unix/config.it delete
browser/installer/unix/header.png delete
browser/installer/unix/installer.cfg delete
browser/installer/unix/talkback.jst delete
browser/installer/unix/watermark.png delete
browser/installer/unix/xpcom.jst delete
browser/locales/en-US/installer/installer.inc delete
toolkit/locales/en-US/installer/unix/install.it delete
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: Future → Firefox 3
l10n trunk landing done.

I cvs removed browser/installer/installer.inc and toolkit/installer/unix/install.it for all locales in mozilla/browser/locales/all-locales.

The patch for that is 1MB, so I won't attach that, even the commit log is lengthy, so I'll do that as an attachment.
Filed bug 427965 on the windows/install.it, including rationale.

Thanks to Phil for just getting this fixed for 1.9.
Status: RESOLVED → VERIFIED
No longer blocks: 444605
Depends on: 595616
You need to log in before you can comment on or make changes to this bug.