345893 - Text in Safe Browsing overlay not visible with large font / high contrast theme

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Wayne DeAngelo]

Env: Bon Echo nightly build 20070724, Test done on IBM T42 ThinkPad.


Description:  
With Extra Large Fonts set, the "Anti-Phishing Privacy Policy" pop-up message box  cannot be seen in its entirety, and the window cannot be sized and does not have scroll bars.  This is when selecting Google as the anti-phishing security provider in the Tools, Options, Advanced, Anti-Phishing dialog.
	
Steps to Reproduce:
1. Set High Contrast #1 (extra large) in the Windows Control Panel Accessibility Options, Display page.
2. In Firefox, open the Tools, Options, Advanced page.
3. Select the Anti-Phishing tab.
4. Select the checkbox "Check to see if the site I'm visiting might be a scam"
5. Select the "By asking: Google" option.  
6. Note the resulting popup message (Anti-Phishing Privacy policy) is not completely visible.  The buttons at the bottom of the popup are not visible.  There is no scroll bar, and the window is not sizable.
	
Expected Result:
The entire message should be viewable.  There should be scroll bars presented if the entire text message and buttons cannot be displayed in the window.

Comment 1

[Mark Pilgrim (inactive)]

http://lxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/safebrowsing/browser-protection.css
http://lxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/safebrowsing/browser-protection.css

.safebrowsing-palm-fixed-width (the container for the speech bubble) has a width set in px.

Other elements have font sizes set in px.

Other elements have hardcoded colors that are not CSS 2 System Colors.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Ugh. Tony, what's the estimate to fix? mconnor's suggesting moving to the notificationBox instead of the bubble to reuse existing code there ....

Comment 3

[Tony Chang (Google)]

(In reply to comment #2)
> Ugh. Tony, what's the estimate to fix? mconnor's suggesting moving to the
> notificationBox instead of the bubble to reuse existing code there ....

I'll try to post a patch by end of day tomorrow.  Seems like the notification box might be easy to miss even with the page greyed out.  Anyway, I'll try some things.

Comment 4

[Tony Chang (Google)]

Questions for accessibility people:

What unit should I use to set font-size?  Can I use the small/medium/large/x-large values or should I just use percentages?

Is it ok to use white background with black text or do all colors need to be CSS 2 System Colors? (the "tail" of the bubble is a white png image, so if I want the color to match, I'd have to force it)

Comment 5

[Mike Connor [:mconnor]]

Tony, using PRIORITY_CRITICAL_BLOCK for the notificationbox means you get the content blocking free (once bug 343574 lands) and a solid red infobar (instead of the yellow/neutral one we've been using).

It also means you don't need to localize the height/width styling (to allow localizers to specify things properly)

Comment 6

[Tony Chang (Google)]

(In reply to comment #5)
> Tony, using PRIORITY_CRITICAL_BLOCK for the notificationbox means you get the
> content blocking free (once bug 343574 lands) and a solid red infobar (instead
> of the yellow/neutral one we've been using).

I'll try this out once trunk finishes building.  It may also fix bug 341950 (anti-phishing not working on trunk) for free.

Comment 7

[Tony Chang (Google)]

Attachment: v1: add scrollbars if text overflows

This patch does the following:
- make text sizes relative
- add scrollbar if we're too tall
- if we're falling off the left edge of the screen, switch to "floating" mode
- moves images into CSS so they can be themed

The notification box isn't as good because it not as trustworthy (doesn't extend into chrome) and it doesn't periodically refresh (it might make the canvas snapshot in a partially rendered state).

Comment 8

[Tony Chang (Google)]

Attachment: v2: same as before, remove some debug code

Comment 9

[Tony Chang (Google)]

on trunk

Comment 10

[Mike Schroepfer]

Comment on attachment 231119 [details] [diff] [review]
v2: same as before, remove some debug code

a=schrep for drivers.

Comment 11

[Tony Chang (Google)]

on branch

Comment 12

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381