345899 - Protect against XMLHttpRequest statusText not being available

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

When a network connection is unavailable we throw in the EM when getting the statusText from XMLHttpRequest. Patch coming up.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Simple fix. Without this we throw and STATUS_FAILURE is never returned for an add-on during an update check.

Comment 2

[Robert Strong (they/them - no direct email)]

Requesting blocking 2.0 - this can prevent the appearance of a hang during an update check when a network connection is unavailable.

Comment 3

[(not reading, please use [e-mail] instead)]

shouldn't this be something like:

+    // this can fail when a network connection is not present.
+    var statusText;
+    try {
+      statusText = request.statusText;
+    }
+    catch (e) {
+      status = 0;
+    }
     // When status is 0 we don't have a valid channel.
     if (status == 0)
       statusText = "nsIXMLHttpRequest channel unavailable";

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 230623 [details] [diff] [review]
patch

r=sspitzer, my nit is my own js coding style, and does not match this file.

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 230623 [details] [diff] [review]
patch

Simple patch that adds a try catch around getting the XMLHttpRequest statusText property for the no network connection case where XMLHttpRequest will throw

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230623 [details] [diff] [review]
patch

a=drivers. Please land this on the MOZILLA_1_8_BRANCH.

Comment 8

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH