Closed Bug 345916 Opened 18 years ago Closed 18 years ago

Document the Recently Closed Tabs menu and the keyboard shortcut

Categories

(Firefox Graveyard :: Help Documentation, defect)

2.0 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 2 beta2

People

(Reporter: ronny.perinke, Assigned: ronny.perinke)

References

Details

(Keywords: fixed1.8.1, late-l10n)

Attachments

(1 file, 4 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1b1) Gecko/20060725 Firefox/2.0b1 (Sephiroth/AXP)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1b1) Gecko/20060725 Firefox/2.0b1 (Sephiroth/AXP)

Document "Recently Closed Tabs" and the keyboard shortcut for it.

Reproducible: Always
Attached patch document it (obsolete) — Splinter Review
updates shortcuts.xhtml, tabbed_browsing.xhtml and menu_reference.xhtml
OS: Windows XP → All
Version: unspecified → 2.0 Branch
We should probably add this (and other new shortcuts?) to this page: http://www.mozilla.org/support/firefox/keyboard.
djst, around to do this? If not, I'll get around to it sometime.
Comment on attachment 230655 [details] [diff] [review]
document it

>Index: browser/locales/en-US/chrome/help/tabbed_browsing.xhtml
>===================================================================
  
>+<p>&brandShortName; keeps a list of tabs that you have closed recently. You can restore
>+  each one by selecting the appropriate tab from <span class="menuPath">History &gt; 
>+  Recently Closed Tabs</span> or you can restore all with <span class="menuPath">
>+  Open All in Tabs</span>. Alternately, you can press &ctrlKey;+&shiftKey;+
>+  <kbd>T</kbd> to open them in reverse order.</p>

Shouldn't that be "&accelKey;+&shiftKey;+<kbd>T</kbd>"?

I don't have a Mac, but I think they use the Cmd key, and &accelKey; will take care of that.
Same thing in shortcuts.xhtml.
(In reply to comment #4)
> (From update of attachment 230655 [details] [diff] [review] [edit])
> >Index: browser/locales/en-US/chrome/help/tabbed_browsing.xhtml
> >===================================================================
> 
> >+<p>&brandShortName; keeps a list of tabs that you have closed recently. You can restore
> >+  each one by selecting the appropriate tab from <span class="menuPath">History &gt; 
> >+  Recently Closed Tabs</span> or you can restore all with <span class="menuPath">
> >+  Open All in Tabs</span>. Alternately, you can press &ctrlKey;+&shiftKey;+
> >+  <kbd>T</kbd> to open them in reverse order.</p>
> 
> Shouldn't that be "&accelKey;+&shiftKey;+<kbd>T</kbd>"?
> 
> I don't have a Mac, but I think they use the Cmd key, and &accelKey; will take
> care of that.
> Same thing in shortcuts.xhtml.
> 

I think you are right. XUL says modifiers="accel,shift".
Attached patch document it v1.5 (obsolete) — Splinter Review
use &accelKey; (see comment #4)
Attachment #230655 - Attachment is obsolete: true
Since you're touching menu_reference.xhtml, can you document History->Recently Closed Tabs as well, please? (I filed bug 343807 for that.)
Assignee: nobody → ronny.perinke
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: late-l10n
Target Milestone: --- → Firefox 2 beta2
Comment on attachment 230816 [details] [diff] [review]
document it v1.5

>Index: browser/locales/en-US/chrome/help/tabbed_browsing.xhtml
>+<p>&brandShortName; keeps a list of tabs that you have closed recently. You can restore
>+  each one by selecting the appropriate tab from <span class="menuPath">History &gt; 
"You can restore any tab by selecting it from..."
>+  Recently Closed Tabs</span>
Full stop after that.

>+  or you can restore all with <span class="menuPath">Open All in Tabs</span>.
"You can restore all tabs by selecting History>Recently Closed Tabs->Open All in Tabs."
(For clarity, use the full menu path).
Attached patch document it v2.0 (obsolete) — Splinter Review
- the list of tabs is window-speccific (I hope the explanation is clear enough)
- contains Steffen's corrections
- does not change menu_reference.xhtml anymore (see bug #343807)
Attachment #230816 - Attachment is obsolete: true
Comment on attachment 231158 [details] [diff] [review]
document it v2.0

>Index: browser/locales/en-US/chrome/help/tabbed_browsing.xhtml
>+  Alternately, you can press &accelKey;+&shiftKey;+<kbd>T</kbd> to open them in reverse 
>+  order.</p>
Press ... to open them one by one in reverse order.

r=me.
Attachment #231158 - Flags: review+
*** Bug 343807 has been marked as a duplicate of this bug. ***
Depends on: 342700
So one last round, please.
Attached patch document it v2.5 (obsolete) — Splinter Review
(In reply to comment #12)
> So one last round, please.
> 

here we go ;-)
Attachment #231158 - Attachment is obsolete: true
Attachment #232230 - Flags: review?(steffen.wilberg)
Comment on attachment 232230 [details] [diff] [review]
document it v2.5

>Index: browser/locales/en-US/chrome/help/shortcuts.xhtml
>+      <td>Restore Recently Closed Tabs</td>
>+      <td>&accelKey;+&shiftKey;+<kbd>T</kbd></td>
>+    </tr>
s/Tabs/Tab/, since we're restoring one tab at a time.


>Index: browser/locales/en-US/chrome/help/tabbed_browsing.xhtml
> <h2 id="closing_tabs">Closing Tabs</h2>
This should now be "Closing and Restoring Tabs".
 
>+<p>&brandShortName; keeps a list of recently closed tabs for every open &brandShortName; 
>+  window.
"&brandShortName; windows keep a list of tabs you closed recently."

I'll attach a new patch for checkin in a minute.
Attachment #232230 - Flags: review?(steffen.wilberg) → review+
Comment on attachment 232230 [details] [diff] [review]
document it v2.5

Oh, one last nit:

>Index: browser/locales/en-US/chrome/help/menu_reference.xhtml
>+  <h3 id="closed_tabs">Recently Closed Tabs</h3>
>+  <p>Allows you to restore a recently closed tab by selecting it from the list.
"to restore a tab you closed recently in the current window"
Attached patch final patchSplinter Review
Attachment #232230 - Attachment is obsolete: true
Attachment #232420 - Flags: review+
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Summary: Document Undo Close Tab and the keyboard shortcut → Document the Recently Closed Tabs menu and the keyboard shortcut
Attachment #232420 - Flags: approval1.8.1?
Flags: blocking-firefox2?
Comment on attachment 232420 [details] [diff] [review]
final patch

a=schrep for drivers.
Attachment #232420 - Flags: approval1.8.1? → approval1.8.1+
Flags: blocking-firefox2? → blocking-firefox2+
Target Milestone: Firefox 2 beta2 → Firefox 2
Fixed on branch.
Keywords: fixed1.8.1
Target Milestone: Firefox 2 → Firefox 2 beta2
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: