345929 - User matching not called for requestee fields in post_bug.cgi

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

Now that we can set flags on bug creation, we have to validate requestee fields using User::match_field() too.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Max Kanat-Alexander]

Be careful not to re-create the "we lose the attachment if there's an intermediate page" bug.

Comment 3

[Frédéric Buclin]

Max, we already have user-matching for the assignee, QA contact and CC list, so you already can have the intermediate page at this point. That's where AJAX would be useful: when clicking "Commit", User::match_field() should be called and a popup should appear where we ask the user to choose the correct user(s) and when the user clicks "OK", go submit the bug creation page to post_bug.cgi. But that's another bug.(*)

This patch is important because Bugzilla::Flag::validate() assumes that all requestees are valid.


(*) That's the kind of problems where I would like to see AJAX implemented independently of the full work gandalf is doing. That's the kind of small implementations of AJAX which would really help.

Comment 4

[Frédéric Buclin]

Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.159; previous revision: 1.158
done