345955 - Remove obsolete strings from pref locale files

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[u60234]

There are some entity definitions and strings in preferences locale files that are not used. I suggest we remove them.

content.dtd:
The feeds pref strings now live in feeds.dtd (bug 340677).

fonts.dtd:
The pref window in Firefox have never had font options for Fantasy or Cursive, and the "fontsize.units" entity have never been used.

permissions.dtd:
"addpermission.label" has AFAICT never been used.

preferences.properties:
The "blankpage" and "bookmarkjoiner" strings were added in bug 340677 but is currently not used. Jeff, do you need these in the future?
The "choosehomepage", "choosebookmark", and "choosefile" strings has AFAICT never been used.
The "setMasterPassword" and "changeMasterPassword" strings were obsoleted in bug 340677.
The "downloadpermissions" strings were added in bug 241705 and seem to have been meant for a never implemented site manager for downloading of files.
All but two of the master password strings in this file are unused after they were copied to toolkit in bug 285158.
The "fontScalingResolutionFormat" string was obsoleted in bug 323962.

sanitize.dtd:
The "sanitizeOnShutDown" entities were obsoleted in bug 340677.

Comment 1

[u60234]

Attachment: diff

Jeff, I don't know if you were planning on removing some of these strings in follow up's to bug 340677, so perhaps I should wait with requesting review until you have finished your work?

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 230718 [details] [diff] [review]
diff

Dangit dangit dangit...I meant to do this before the l10n freeze but forgot.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 230718 [details] [diff] [review]
diff

needs update; some of these strings are already gone.

Comment 4

[u60234]

Attachment: updated patch

The remaining strings to be removed.

I also found another string in preferences.properties that is obsolete, "addReader". It was introduced (and used) in the "Feeds UI" patch in bug 340677. That patch was then obsoleted by the final patch in that bug which kept the string but never used it.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 245884 [details] [diff] [review]
updated patch

r=mano

Comment 6

[Asaf Romano (gone)]

mozilla/browser/locales/en-US/chrome/browser/preferences/fonts.dtd 1.13
mozilla/browser/locales/en-US/chrome/browser/preferences/permissions.dtd 1.5
mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties 1.12