346010 - Decom nsIJAR by merging it into nsIZipReader

Status: RESOLVED FIXED

(Core :: Networking: JAR, defect)

Description

[Alfred Kayser]

nsIJAR is only used to define getCertificatePrincipal and ManifestCount for a ZipReader. By moving nsIJAR into nsIZipReader, we can skip on a number of needless do_QueryInterfaces (as the underlying object is always the same):
    nsCOMPtr<nsIJAR> systemCertJar(do_QueryInterface(systemCertZip, &rv));
    if (NS_FAILED(rv)) return NS_ERROR_FAILURE;
    rv = systemCertJar->GetCertificatePrincipal(nsnull,
                                                getter_AddRefs(mSystemCertificate));
becomes:
    rv = systemCertZip->GetCertificatePrincipal(nsnull,
                                                getter_AddRefs(mSystemCertificate));

Callers are:
http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsSoftwareUpdateRun.cpp#109
http://lxr.mozilla.org/seamonkey/source/caps/src/nsScriptSecurityManager.cpp#2645
http://lxr.mozilla.org/seamonkey/source/modules/libjar/nsJARChannel.cpp#480

Comment 1

[Alfred Kayser]

Darin, what do you think about this?

Comment 2

[Makoto Kato [:m_kato]]

Attachment: patch v1

Comment 3

[Alfred Kayser]

Looks good!

Comment 4

[(dormant account)]

This code simplification looks good to me. Benjamin can we take a change that moves methods between public interfaces like this?

Comment 5

[Benjamin Smedberg]

They aren't frozen, are they? Should be fine.

Comment 6

[Makoto Kato [:m_kato]]

landed
http://hg.mozilla.org/mozilla-central/rev/9dbceefc8c6c