346150 - Fix setting an image as wallpaper in Cairo builds

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Frank Wein [:mcsmurf]]

When you in SeaMonkey cairo builds currently try to set an image as wallpaper you either get this error in Error Console:
 Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWindowsHooks.setImageAsWallpaper]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://communicator/content/nsContextMenu.js :: anonymous :: line 612"  data: no]
or your image will be turned upside down and twisted when it's set as wallpaper.

The attached patch will fix this, it's the patch from Bug 328354 ported to SeaMonkey winhooks code.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[Frank Wein [:mcsmurf]]

Comment on attachment 230945 [details] [diff] [review]
Patch

This patch basically already got review in Bug 328354, so you do not need to re-check everything.

Comment 3

[jag (Peter Annema)]

Comment on attachment 230945 [details] [diff] [review]
Patch

Move the |rv = NS_OK;| before the |do|-loop and r+sr=jag

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Patch to checkin

Comment 5

[Frank Wein [:mcsmurf]]

Patch has been checked in by timeless.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Configure arguments
--enable-application=suite --enable-default-toolkit=cairo-windows --without-system-jpg --without-system-zlib --enable-extensions=default,tasks --enable-crypto --disable-auto-deps --disable-debug --enable-optimize --enable-svg --enable-canvas

build ID: 2006-10-15-06 of SeaMonkey trunk under Windows XP; I successfully set images as wallpaper from the browser.