Fix setting an image as wallpaper in Cairo builds

VERIFIED FIXED

Status

SeaMonkey
UI Design
--
major
VERIFIED FIXED
12 years ago
10 years ago

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Tracking

Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
When you in SeaMonkey cairo builds currently try to set an image as wallpaper you either get this error in Error Console:
 Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWindowsHooks.setImageAsWallpaper]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://communicator/content/nsContextMenu.js :: anonymous :: line 612"  data: no]
or your image will be turned upside down and twisted when it's set as wallpaper.

The attached patch will fix this, it's the patch from Bug 328354 ported to SeaMonkey winhooks code.
(Assignee)

Comment 1

12 years ago
Created attachment 230945 [details] [diff] [review]
Patch
Assignee: guifeatures → bugzilla
Status: NEW → ASSIGNED
(Assignee)

Comment 2

12 years ago
Comment on attachment 230945 [details] [diff] [review]
Patch

This patch basically already got review in Bug 328354, so you do not need to re-check everything.
Attachment #230945 - Flags: superreview?(jag)
Attachment #230945 - Flags: review?(jag)

Comment 3

12 years ago
Comment on attachment 230945 [details] [diff] [review]
Patch

Move the |rv = NS_OK;| before the |do|-loop and r+sr=jag
Attachment #230945 - Flags: superreview?(jag)
Attachment #230945 - Flags: superreview+
Attachment #230945 - Flags: review?(jag)
Attachment #230945 - Flags: review+
(Assignee)

Comment 4

12 years ago
Created attachment 231070 [details] [diff] [review]
Patch to checkin
(Assignee)

Comment 5

12 years ago
Patch has been checked in by timeless.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Verified FIXED using:

Configure arguments
--enable-application=suite --enable-default-toolkit=cairo-windows --without-system-jpg --without-system-zlib --enable-extensions=default,tasks --enable-crypto --disable-auto-deps --disable-debug --enable-optimize --enable-svg --enable-canvas

build ID: 2006-10-15-06 of SeaMonkey trunk under Windows XP; I successfully set images as wallpaper from the browser.
Status: RESOLVED → VERIFIED

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.