Closed
Bug 346190
Opened 18 years ago
Closed 18 years ago
updateStyleSheetForObject needs refactoring
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jminta, Assigned: jminta)
Details
Attachments
(1 file)
|
5.06 KB,
patch
|
jminta
:
first-review+
|
Details | Diff | Splinter Review |
spinoff from bug 344452. This function is really hard to read.
|
Assignee | |
Comment 1•18 years ago
|
||
Reorganized to group all of the calendar/category distinction bits and to remove some superfluous function declarations to make this easier to read. This is critical due to the extra bug in calendarUtils.js
|
|
Assignee | |
Comment 2•18 years ago
|
||
Comment on attachment 231021 [details] [diff] [review] as requested + ruleFunc = function(aRule) { Anonymous functions are bad! x2. Let's also call it ruleUpdaterFunc. + if (color) { + rule.style.border = color + " solid 2px"; + } you want aRule. r=dmose with those.
Attachment #231021 -
Flags: first-review?(dmose) → first-review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•