updateStyleSheetForObject needs refactoring

RESOLVED FIXED

Status

Calendar
Internal Components
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Joey Minta, Assigned: Joey Minta)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
spinoff from bug 344452.  This function is really hard to read.
(Assignee)

Comment 1

12 years ago
Created attachment 231021 [details] [diff] [review]
as requested

Reorganized to group all of the calendar/category distinction bits and to remove some superfluous function declarations to make this easier to read.  This is critical due to the extra bug in calendarUtils.js
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #231021 - Flags: first-review?(dmose)
(Assignee)

Comment 2

12 years ago
Comment on attachment 231021 [details] [diff] [review]
as requested

+        ruleFunc = function(aRule) {
Anonymous functions are bad! x2.  Let's also call it ruleUpdaterFunc.

+            if (color) {
+                rule.style.border = color + " solid 2px";
+            }
you want aRule.

r=dmose with those.
Attachment #231021 - Flags: first-review?(dmose) → first-review+
(Assignee)

Comment 3

12 years ago
patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.