346265 - checksetup.pl should use Getopt::Long instead of its current hack

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Max Kanat-Alexander]

Getopt::Long is part of the standard perl distribution. Right now, instead of Getopt::Long, we're using a hacky way of calling grep() on @ARGV to get the switches.

Instead, we should use Getopt::Long!

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This patch depends on the patch for bug 346212 being checked in first.

I tested, and this behaves exactly the same as checksetup used to, except that you can now specify the "answers" file at any part of the argument list you'd like. (Previously you *had* to specify it as the very first argument.)

It's true that the patch looks kind of funky with how it creates the BEGIN block and all that. Eventually that will get fixed in a future patch where I eliminate as many BEGIN blocks from checksetup.pl as possible.

I added the $VERSION variable so that I could have the automatic --version output from Getopt::Long.

Comment 2

[Max Kanat-Alexander]

Requesting approval directly, as module owner.

Comment 3

[Max Kanat-Alexander]

Attachment: v2

Turns out that perl 5.8.0 doesn't support the auto_version option for Getopt::Long. This patch removes that, and the $VERSION var that I created.

Comment 4

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.517; previous revision: 1.516
done