346291 - Session Restore in Full Privacy mode populating some fields on restore

Status: VERIFIED INCOMPLETE

(Firefox :: Session Restore, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Some form fields were being repopulated in non-ssl pages with user_pref("browser.sessionstore.privacy_level", 2);

Comment 1

[Rob Campbell [:rc] (:robcee)]

for details, see http://litmus.mozilla.org/single_result.cgi?id=21944

to reproduce: change prefs.js to include user_pref("browser.sessionstore.privacy_level", 2);

open a non-ssl page with some text fields on it. Change the contents of the forms. Kill browser, reopen and restore the session. Some fields are repopulated with their previous contents.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Dietrich, please nominate for blocking if you think this is megabad.

Comment 3

[Tracy Walker [:tracy]]

data from litmust "test form" fields that are not repopulating with pre Kill data: text, select, select muliple, checkbox, radio.

textarea and password are retained.

note: do we need a session restore component?  If not, what bucket does this belong in... Startup and Profile   ... Form Manager?

Comment 4

[Dietrich Ayala (:dietrich)]

I was not able to reproduce this using the latest branch nightly. I used the same form as the test case, and no textual data was restored to either ssl or non-ssl forms when the pref was set to 2.

Also, (In reply to comment #3)
> data from litmust "test form" fields that are not repopulating with pre Kill
> data: text, select, select muliple, checkbox, radio.
> 
> textarea and password are retained.

Which form is this? The litmus test case this bug is linked to doesn't have any textareas that I can see. The expected behavior wrt to form data is to save/restore input and textarea fields only.

> note: do we need a session restore component?  If not, what bucket does this
> belong in... Startup and Profile   ... Form Manager?
> 

Session restore bugs are currently in Tabbed Browser component. I agree that this doesn't make much sense here. It should probably have it's own component.

Comment 5

[Tracy Walker [:tracy]]

changing component to Tabbed browser and filing a seperate bug for the issue I posted in comment #3

Comment 6

[Simon Bünzli]

(In reply to comment #1)
> open a non-ssl page with some text fields on it.

That page ( http://landfill.mozilla.org/bugzilla-tip/ ) nicely exposes the issues mentioned in bug 346337 (as filed by Tracy) but doesn't expose the original bug in my case.

For further debugging: could we please get a copy of the file sessionstore.bak (found in the used profile) after step #7 of the test case?

Comment 7

[Simon Bünzli]

Closing this bug as INCOMPLETE. Should the bug still be reproducible, please reopen _and_ attach a sessionstore.js which leads to this issue.