346292 - Keyboard navigation issues in view/minimonth after switching to different view

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060728 Calendar/0.3a2+

Keyboard navigation issues with views/minimonth after switching to different view.

Steps to Reproduce:
1. Start Sunbird with clean profile
2. Select any view (e.g. Week view)
3. Use PageUp/PageDown keys to navigate to prev./next week
4. Switch to another view using keyboard command or toolbar (e.g. Day view)
5. Use PageUp/PageDown keys to navigate to prev./next day

Actual Results:
Nothing happens in view, the same day/week/month stays selected. But in minimonth you can see that the selected date is moved according to the prev. selected view. 
Example: After switching from Week view to Day view the PageUp/PageDown still moves the selected day in minimonth by +/- one week instead of +/- one day. And the date shown in Day view does not change at all.

Expected Results:
PageUp/PageDown key commands work and move the view by the correct amount of days/weeks/months. View and minimonth stay in sync.

Additional Information:
This might be a kind of focus problem after landing of Bug 268621 because it works after you perform an additional click into the view.
Happens also with Lightning/0.1+ (20060726) and Thunderbird 1.5.0.4.

Comment 1

[Joey Minta]

I'd bet this was caused by bug 329225, which would move focus to the minimonth, rather than keep it in the views.

Comment 2

[Joey Minta]

Attachment: unification and .focus()

This was caused by bug 329225.  By selecting the minimonth's day, we moved focus there, which thereby breaks the key-listeners in the view.  So, the substantive change here is to call currentView().focus();

Someone tell duplicate code to go run and I hide, because I'm going to hunt it down and kill it.

Comment 3

[Joey Minta]

Comment on attachment 231109 [details] [diff] [review]
unification and .focus()

r=dmose

Comment 4

[Joey Minta]

patch checked in.

Comment 5

[Stefan Sitter [:ssitter]]

Verified with Sunbird/0.3a2+ (2006080207).
Verified with Thunderbird 1.5.0.5 (20060719) + Lightning/0.1+ (2006080207).

Comment 6

[Damian Szczepanik]

Litmus testcase 2632 created