346343 - Clean up all of checksetup prior to localconfig code

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Max Kanat-Alexander]

I'm about to dive into the localconfig code in checksetup.pl, and put it in a module, but before I do that, I want to clean up all the code before it in checksetup, and get it exactly the way I'd like it to be.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, you'll notice that I've done several things in this patch.

First off, I've centralized the Win32 checks into a constant called ON_WINDOWS, which is more readable than the regex against $^O that we currently use.

Also, I've moved all of the "require" of Bugzilla modules into one place in checksetup. Now that Bugzilla modules don't perform code outside of subroutines, it's safe to "require" them at the top.

I've tested this on a system with no data/ directory, a system without any of the required modules, and both. I've also tested it on a normal system. It works fine.

Comment 2

[Max Kanat-Alexander]

Requesting approval directly, as module owner.

Comment 3

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.520; previous revision: 1.519
done
Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.46; previous revision: 1.45
done
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.10; previous revision: 1.9
done