Closed Bug 346344 Opened 18 years ago Closed 18 years ago

Move checksetup's localconfig-handling code into Bugzilla::Install::Localconfig

Categories

(Bugzilla :: Installation & Upgrading, enhancement)

2.23
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file)

checksetup has a whole section that creates and updates localconfig.

The next step in the checksetup cleanup is to move this code into a module. It has to be its own module, because the code has its own particular set of assumptions. That is, params and templates don't exist, but we can load any module we'd like.
Attached patch v1Splinter Review
Okay! This was one of the craziest patches I ever had to write. :-)

Not only did I move this code into a module, I made it behave much more sensibly.

Some important changes:

1) We use a Safe to read localconfig.

2) We only read out of localconfig the variables we expect to find there. Anybody who has customized their localconfig will have to add their variables to our "LOCALCONFIG_VARS" constant.

3) localconfig vars from here on out must be scalars. (They all are, currently.)

4) It changes the format of the $answers file for specifying localconfig variables. I've never known anybody to do this, so I don't think this is a huge breaking change.

This is a massive patch--if it had to undergo review, the review would be a nightmare. However, I've tested it many many ways, and it passes all tests that I have devised.
Okay, I'm the module owner. Requesting approval directly for this monstrous monster. It's been thoroughly tested and debugged, and it passes runtests.
Status: NEW → ASSIGNED
Flags: approval?
Keywords: relnote
Blocks: 346375
Flags: approval? → approval+
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.521; previous revision: 1.520
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Localconfig.pm,v
done
Checking in Bugzilla/Install/Localconfig.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Localconfig.pm,v  <--  Localconfig.pm
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Blocks: 42354
Added to the release notes on bug 255155.
Keywords: relnote
The correct bug number for those release notes is actually bug 349423.
You need to log in before you can comment on or make changes to this bug.