346362 - document.evaluate(.., contextNode, ...) should raise an exception if document != contextNode.ownerDocument

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Sylvain Pasche]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1b1) Gecko/20060727 BonEcho/2.0b1
Build Identifier: 

The spec says:

"contextNode of type Node:
... If the XPathEvaluator was obtained by casting the Document then this must be owned by the same document ..."

Reproducible: Always

Comment 1

[Sylvain Pasche]

Attachment: testcase from Hallvord R. M. Steen

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 3

[Boris Zbarsky [:bzbarsky]]

This is causing compat issues with other UAs; we should really get this fixed for 1.9.

Comment 4

[Matthew Imakyure]

document.evaluate(..., document, ...) throws an exception now.  It doesn't own itself.  Was this intended?

Comment 5

[Peter Van der Beken [:peterv]]

Not really, though the spec wording should probably be improved a bit.

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: Document fix v1

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

I believe this caused bug 348466.  Is that just a dupe of this bug, now?

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 348466 has been marked as a duplicate of this bug. ***

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 233214 [details] [diff] [review]
Document fix v1

r+sr=bzbarsky

Comment 10

[Boris Zbarsky [:bzbarsky]]

Can we test this in the XSLT test suite?  Or do we need to add some XSLT mochitests?

Comment 11

[Peter Van der Beken [:peterv]]

Or we could integrate the w3c DOM Level 3 XPath testsuite (see http://dev.w3.org/cvsweb/2001/DOM-Test-Suite/tests/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR.xml?rev=1.3&content-type=text/x-cvsweb-markup).

Comment 12

[Boris Zbarsky [:bzbarsky]]

That sounds ideal, in some ways.