Closed Bug 346447 Opened 19 years ago Closed 19 years ago

loadFolderAndReplace=false ignores "loading" tabs

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 alpha1

People

(Reporter: pablo, Assigned: pablo)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 1 obsolete file)

addressing coments via irc
2.52 KB, patch
asaf
: review+
Details | Diff | Splinter Review
1.8.1 branch version
1.30 KB, patch
beltzner
: approval1.8.1+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060729 BonEcho/2.0b1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060729 BonEcho/2.0b1 If you "open in tabs" a live bookmark or a folder, it replaces tabs that are already loading tabs, even when it shouldn't Reproducible: Always Steps to Reproduce: 1.change loadFolderAndReplace to false 2.Load a live bookmark 3.While loading, open another one Actual Results: Tabs that are still loading are relpaced Expected Results: loading tabs shouldn't be replaced
Attached patch Skip loading tabs (obsolete) — — Splinter Review
Attachment #231251 - Flags: review?(mconnor)
Assignee: nobody → pablo
Status: UNCONFIRMED → NEW
Ever confirmed: true
Just addressing comments on indentation and spacing
Attachment #231251 - Attachment is obsolete: true
Attachment #231254 - Flags: review?(bugs.mano)
Attachment #231251 - Flags: review?(mconnor)
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → Trunk
Comment on attachment 231254 [details] [diff] [review] addressing coments via irc r=mano
Attachment #231254 - Flags: review?(bugs.mano) → review+
Whiteboard: [checkin needed]
Checked in on the trunk. mozilla/browser/components/bookmarks/content/bookmarks.js 1.124 mozilla/browser/components/places/content/controller.js 1.96
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha1
Attached branch version
Attachment #232711 - Flags: approval1.8.1?
Comment on attachment 232711 [details] [diff] [review] 1.8.1 branch version a=drivers, please land (or get gavin to land) on the branch
Attachment #232711 - Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [checkin needed (1.8 branch)]
Checked in on the branch. mozilla/browser/components/bookmarks/content/bookmarks.js 1.104.2.19
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: