346480 - Bookmarking about:blank from Bookmarks Manager gives inconsistent results

Status: VERIFIED INVALID

(Camino Graveyard :: Bookmarks, defect)

Description

[Trevor Johns]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060728 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b1) Gecko/20060728 Camino/1.0+

When bookmarking about:blank under normal circumstances, the browser attempts to bookmark the last page visited. However, when bookmarking about:blank from the Bookmarks Manager, about:blank is bookmarked instead.

Reproducible: Always

Steps to Reproduce:
1. Navigate to any site.
2. Navigate to about:blank.
3. Choose Bookmarks > Create Bookmark.
4. Open Bookmarks Manager, press Bookmarks > Create Bookmark.

Actual Results:  
In the first case, the bookmark is created pointing to the first site visited. In the second case, the bookmark is created pointing to about:blank.

Expected Results:  
The location bookmarked should be consistent, regardless of how it is created.

Notes:
If about:blank is the first site visited (meaning it is set as the home page), then attempting to create a bookmark through the Bookmark Manager will fail on nightly builds. If the '+' button is used to do so, it will remain depressed after selecting 'Add Bookmark'. On 1.0.2, it will instead try to create a bookmark pointing towards about:bookmarks.

Comment 1

[Stuart Morgan]

(In reply to comment #0)
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Navigate to any site.
> 2. Navigate to about:blank.
> 3. Choose Bookmarks > Create Bookmark.
> 4. Open Bookmarks Manager, press Bookmarks > Create Bookmark.
> 
> Actual Results:  
> In the first case, the bookmark is created pointing to the first site visited.
> In the second case, the bookmark is created pointing to about:blank.

I see exactly the opposite behavior (assuming "Create Bookmark" means "Add Page to Bookmarks...").  about:blank isn't added to session history, so there's no way to know that's where you came from.  If you go to a page, then about:blank, then toggle the bookmark manager on and off, you'll be back at the page you visited before about:blank for the same reason. Similarly, if you go somewhere, then go to about:blank, then go somewhere else, then go back, you skip over about blank. In general, about:blank is not a real page, so you shouldn't expect it to be treated as one. I'm trying to imagine a non-contrived situation where someone would explicitly visit about:blank, and am failing, so I don't see that as an issue.

As this has nothing to do with the bookmark manager itself, I'm closing this as INVALID.

(The only thing here that sounds like a bug is the bookmark manager isn't validating bookmark creation correctly in the no-history (about:blank home page) case, but since that's tangential it should be filed as a new bug.)

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The first case is bug 302614 (as is the second, actually).

I think this is all a dupe, actually.  (In that last paragraph, 1.0.2 is actually doing the right thing; I wonder how it broke in the nightlies?)